Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72179] Show description of boolean build parameter values #8606

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

daniel-beck
Copy link
Member

See JENKINS-72179. Amends #3921.

Testing done

Navigated to the affected page:

Screenshot

Proposed changelog entries

  • Show the description of boolean build parameter values on the Parameters view. (regression in 2.179)

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do find it strange though that (all the?) other form taglibs can take a description directly yet checkbox does not.

@daniel-beck daniel-beck added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases bug For changelog: Minor bug. Will be listed after features labels Oct 13, 2023
@NotMyFault NotMyFault added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed bug For changelog: Minor bug. Will be listed after features labels Oct 13, 2023
@NotMyFault NotMyFault merged commit d6b4637 into jenkinsci:master Oct 19, 2023
15 checks passed
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Oct 30, 2023
@MarkEWaite MarkEWaite mentioned this pull request Oct 30, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants