[JENKINS-72148] Add missing fr properties in package jenkins #8595

jgreffe · 2023-10-11T08:39:50Z

See JENKINS-72148.
Add and translate all the missing *_fr.properties in src/main/resources/jenkins.

Testing done

Proposed changelog entries

JENKINS-72148, add missing fr properties in jenkins resources

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

comment-ops-bot · 2023-10-11T08:40:34Z

I wasn't able to add the following labels: localization hacktoberfest

Check that the label exists and is spelt right then try again.

jgreffe · 2023-10-11T08:40:53Z

/label localization

jgreffe · 2023-10-11T08:41:25Z

/label hacktoberfest

lemeurherve · 2023-10-11T09:18:07Z

Reviewing it.

lemeurherve

Another big PR! 🤯

Note: my NB: comments concern original messages in English, they don't have to be taken in account in this PR.

core/src/main/resources/jenkins/agents/CloudSet/index_fr.properties

core/src/main/resources/jenkins/agents/Messages_fr.properties

.../src/main/resources/jenkins/diagnostics/CompletedInitializationMonitor/message_fr.properties

core/src/main/resources/jenkins/diagnostics/ControllerExecutorsAgents/message_fr.properties

core/src/main/resources/jenkins/diagnostics/ControllerExecutorsNoAgents/message_fr.properties

...c/main/resources/jenkins/tasks/filters/EnvVarsFilterGlobalConfiguration/config_fr.properties

core/src/main/resources/jenkins/tasks/filters/impl/Messages_fr.properties

.../src/main/resources/jenkins/tasks/filters/impl/RetainVariablesLocalRule/config_fr.properties

…r properties (mostly spaces removal)

Co-authored-by: Hervé Le Meur <[email protected]>

jgreffe · 2023-10-11T17:18:25Z

Thanks for your review @lemeurherve 👍🏼
Added a commit with suggestions related to non fr properties here: de41fd7

Co-authored-by: Hervé Le Meur <[email protected]>

lemeurherve

Great job 🙌

Ready for merge IMO

jgreffe · 2023-10-11T17:29:39Z

Great job 🙌

Ready for merge IMO

Team work, thanks for your review & suggestions! ❤️

timja · 2023-10-12T07:42:02Z

slash label localization

comma separated I think for multiple

core/src/main/resources/jenkins/agents/CloudSet/index.properties

core/src/main/resources/jenkins/security/UpdateSiteWarningsConfiguration/config.properties

core/src/main/resources/jenkins/agents/CloudSet/index_fr.properties

core/src/main/resources/jenkins/security/UpdateSiteWarningsConfiguration/config_fr.properties

Co-authored-by: Tim Jacomb <[email protected]>

timja

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[JENKINS-72148] Add missing fr properties in package jenkins

5fe571a

comment-ops-bot bot added the localization label Oct 11, 2023

comment-ops-bot bot added the hacktoberfest label Oct 11, 2023

lemeurherve reviewed Oct 11, 2023

View reviewed changes

jgreffe and others added 2 commits October 11, 2023 19:13

[JENKINS-72148] Apply original messages suggestions and related non f…

de41fd7

…r properties (mostly spaces removal)

Apply suggestions from code review

f9f2b29

Co-authored-by: Hervé Le Meur <[email protected]>

Apply suggestions from code review

301575e

Co-authored-by: Hervé Le Meur <[email protected]>

lemeurherve approved these changes Oct 11, 2023

View reviewed changes

timja reviewed Oct 12, 2023

View reviewed changes

core/src/main/resources/jenkins/agents/CloudSet/index.properties Outdated Show resolved Hide resolved

timja reviewed Oct 12, 2023

View reviewed changes

core/src/main/resources/jenkins/security/UpdateSiteWarningsConfiguration/config.properties Outdated Show resolved Hide resolved

jgreffe commented Oct 13, 2023

View reviewed changes

core/src/main/resources/jenkins/agents/CloudSet/index_fr.properties Outdated Show resolved Hide resolved

jgreffe commented Oct 13, 2023

View reviewed changes

core/src/main/resources/jenkins/security/UpdateSiteWarningsConfiguration/config_fr.properties Outdated Show resolved Hide resolved

Apply suggestions from code review

4aeb6cd

Co-authored-by: Tim Jacomb <[email protected]>

lemeurherve approved these changes Oct 13, 2023

View reviewed changes

jgreffe requested a review from timja October 13, 2023 13:16

timja approved these changes Oct 13, 2023

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 13, 2023

Merge branch 'master' into JENKINS-72148_missing-fr-jenkins

d6e0c83

NotMyFault merged commit 35446c4 into jenkinsci:master Oct 14, 2023
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-72148] Add missing fr properties in package jenkins #8595

[JENKINS-72148] Add missing fr properties in package jenkins #8595

jgreffe commented Oct 11, 2023

Submitter checklist

Maintainer checklist

comment-ops-bot bot commented Oct 11, 2023

jgreffe commented Oct 11, 2023 •

edited

Loading

jgreffe commented Oct 11, 2023

lemeurherve commented Oct 11, 2023

lemeurherve left a comment

jgreffe commented Oct 11, 2023 •

edited

Loading

lemeurherve left a comment

jgreffe commented Oct 11, 2023

timja commented Oct 12, 2023

timja left a comment

[JENKINS-72148] Add missing fr properties in package jenkins #8595

[JENKINS-72148] Add missing fr properties in package jenkins #8595

Conversation

jgreffe commented Oct 11, 2023

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

comment-ops-bot bot commented Oct 11, 2023

jgreffe commented Oct 11, 2023 • edited Loading

jgreffe commented Oct 11, 2023

lemeurherve commented Oct 11, 2023

lemeurherve left a comment

Choose a reason for hiding this comment

jgreffe commented Oct 11, 2023 • edited Loading

lemeurherve left a comment

Choose a reason for hiding this comment

jgreffe commented Oct 11, 2023

timja commented Oct 12, 2023

timja left a comment

Choose a reason for hiding this comment

jgreffe commented Oct 11, 2023 •

edited

Loading

jgreffe commented Oct 11, 2023 •

edited

Loading