Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict helper classes in ScriptListener for internal use #8588

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

daniel-beck
Copy link
Member

While they might be useful for anyone needing to call #fire... methods, that alone is fairly unlikely to be necessary.

See #7056 (comment)

Testing done

None

Proposed changelog entries

None

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

While they might be useful for anyone needing to call #fire...
methods, that alone is fairly unlikely to be necessary.
@daniel-beck daniel-beck requested a review from jglick October 10, 2023 12:49
@daniel-beck daniel-beck changed the title Restrict helper classes for internal use Restrict helper classes in ScriptListener for internal use Oct 10, 2023
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fire* methods are supposed to be public?

@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Oct 10, 2023
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 10, 2023
@daniel-beck
Copy link
Member Author

The fire* methods are supposed to be public?

Do you mean unrestricted? I don't see why not.

@jglick
Copy link
Member

jglick commented Oct 10, 2023

Fine, just checking.

@NotMyFault NotMyFault merged commit 0ace9ad into jenkinsci:master Oct 11, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants