Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72156] Upgrade to Winstone 6.14 which contains an upgrade to Jetty 10.0.17 #8587

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

olamy
Copy link
Member

@olamy olamy commented Oct 10, 2023

Signed-off-by: Olivier Lamy [email protected]

Testing done

  • Started Jenkins with Winstone 6.14 from this pull request on a Linux computer running Java 17
  • Enabled security, registered myself as a user, and allowed logged in users to do anything
  • Installed the markdown plugin and restarted Jenkins
  • Installed the embeddable build status plugin and restarted Jenkins
  • Installed declarative Pipeline and Pipeline plugins and restarted Jenkins
  • Added an inbound agent from a Linux computer
  • Defined and ran a Pipeline job
  • Displayed the embeddable build status of that Pipeline job

Proposed changelog entries

  • Upgrade to Winstone 6.14 which contains an upgrade to Jetty 10.0.17

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Oct 10, 2023

Thanks very much @olamy ! Could you describe any checks you performed in the "Testing done" section so that reviewers know if additional testing is needed before merge?

I've added the checks that I performed. The pull request looks very good to me.

@MarkEWaite MarkEWaite added dependencies Pull requests that update a dependency file rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted developer Changes which impact plugin developers and removed dependencies Pull requests that update a dependency file labels Oct 10, 2023
@MarkEWaite MarkEWaite self-assigned this Oct 10, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 10, 2023
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@MarkEWaite MarkEWaite changed the title Upgrade to Winstone 6.14 which contains an upgrade to Jetty 10.0.17 [JENKINS-72156] Upgrade to Winstone 6.14 which contains an upgrade to Jetty 10.0.17 Oct 11, 2023
@MarkEWaite MarkEWaite merged commit 8792ea0 into jenkinsci:master Oct 11, 2023
15 checks passed
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Oct 29, 2023
… Jetty 10.0.17 (jenkinsci#8587)

Upgrade to Winstone 6.14 which contains an upgrade to Jetty 10.0.17

Signed-off-by: Olivier Lamy <[email protected]>

(cherry picked from commit 8792ea0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants