Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72148] Add missing fr properties in hudson directory #8586

Merged

Conversation

jgreffe
Copy link
Contributor

@jgreffe jgreffe commented Oct 10, 2023

See JENKINS-72148.
Add and translate all the missing *_fr.properties in src/main/resources/hudon and src/main/resources/lib.
Missing *_fr.properties within src/main/resources/jenkins will be processed in another PR.

Testing done

Proposed changelog entries

  • JENKINS-72148, add missing fr properties in hudson and lib resources

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@jgreffe
Copy link
Contributor Author

jgreffe commented Oct 10, 2023

/label localization

Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could do with a review from someone that speaks French better than me :)

@jtnord jtnord requested review from batmat and lemeurherve October 10, 2023 11:34
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great PR, 👏

@lemeurherve
Copy link
Member

Nit: there is a typo in the title, JENKINS is missing its "i" 😉

jgreffe and others added 2 commits October 10, 2023 14:25
@jgreffe
Copy link
Contributor Author

jgreffe commented Oct 10, 2023

/label hacktoberfest

Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that one, looks good otherwise (except the PR title, still missing that "i" and still triggering me 😅)

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui?

…enciesMonitor/description_fr.properties

Co-authored-by: Hervé Le Meur <[email protected]>
@jgreffe jgreffe changed the title [JENKNS-72148] Add missing fr properties in hudson directory [JENKINS-72148] Add missing fr properties in hudson directory Oct 10, 2023
@jgreffe
Copy link
Contributor Author

jgreffe commented Oct 10, 2023

Missed that one, looks good otherwise (except the PR title, still missing that "i" and still triggering me 😅)

Updated :) 🔍

Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NotMyFault NotMyFault added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 13, 2023
@NotMyFault NotMyFault merged commit 7a6e2b0 into jenkinsci:master Oct 14, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants