-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-72148] Add missing fr properties in hudson directory #8586
[JENKINS-72148] Add missing fr properties in hudson directory #8586
Conversation
…dled in another PR
/label localization |
...src/main/resources/hudson/PluginManager/PluginCycleDependenciesMonitor/message_fr.properties
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could do with a review from someone that speaks French better than me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another great PR, 👏
core/src/main/resources/hudson/PluginManager/PluginDeprecationMonitor/description_fr.properties
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/PluginManager/PluginDeprecationMonitor/message_fr.properties
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/util/JenkinsReloadFailed/index_fr.properties
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/util/NoHomeDir/index_fr.properties
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/util/NoHomeDir/index_fr.properties
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/views/BuildButtonColumn/column_fr.properties
Outdated
Show resolved
Hide resolved
core/src/main/resources/hudson/views/BuildButtonColumn/column_fr.properties
Outdated
Show resolved
Hide resolved
Nit: there is a typo in the title, JENKINS is missing its "i" 😉 |
Co-authored-by: Hervé Le Meur <[email protected]>
Co-authored-by: Hervé Le Meur <[email protected]>
/label hacktoberfest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed that one, looks good otherwise (except the PR title, still missing that "i" and still triggering me 😅)
...main/resources/hudson/PluginManager/PluginCycleDependenciesMonitor/description_fr.properties
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oui?
…enciesMonitor/description_fr.properties Co-authored-by: Hervé Le Meur <[email protected]>
Updated :) 🔍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
See JENKINS-72148.
Add and translate all the missing
*_fr.properties
in src/main/resources/hudon and src/main/resources/lib.Missing
*_fr.properties
within src/main/resources/jenkins will be processed in another PR.Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist