Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72143] French translation #8578

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

jgreffe
Copy link
Contributor

@jgreffe jgreffe commented Oct 8, 2023

See JENKINS-72143.

Reported missing keys from hudson/Messages.properties to related Messages_fr.properties

Testing done

Proposed changelog entries

  • Translate hudson/Messages.properties into French.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@jgreffe jgreffe changed the title [JENKIINS-72143] French translation [JENKINS-72143] French translation Oct 9, 2023
@NotMyFault NotMyFault requested a review from a team October 9, 2023 10:48
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional suggestions, good job!

core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
Avertissement : ce plugin est compatible pour Jenkins {0} ou plus récent. \
Jenkins ne démarrera pas ce plugin s''il est installé.
PluginManager.depCompatWarning=\
Avertissement : ce plugin nécessite des versions plus récentes de dépendances et au moins un de ces plugins n''est pas compatible avec la version installée. \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Avertissement : ce plugin nécessite des versions plus récentes de dépendances et au moins un de ces plugins n''est pas compatible avec la version installée. \
Avertissement : ce plugin nécessite des versions plus récentes de dépendances et au moins un de ces dépendances n''est pas compatible avec la version installée. \

The link "dependency" = "plugin" isn't obvious, this equivalent formulation seems better to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
@abhishekmaity
Copy link
Contributor

/label localization

@jgreffe jgreffe requested a review from lemeurherve October 9, 2023 16:25
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last suggestion fixing a typo, LGTM otherwise!

core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
@jgreffe jgreffe requested a review from lemeurherve October 10, 2023 07:32
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 10, 2023
@jgreffe
Copy link
Contributor Author

jgreffe commented Oct 10, 2023

/label hacktoberfest

@NotMyFault NotMyFault merged commit 8ab2aca into jenkinsci:master Oct 11, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants