[JENKINS-72141] French translation #8577

jgreffe · 2023-10-07T21:18:35Z

Reported missing keys from hudson/model/Messages.properties and jenkins/model/Messages.properties to related Messages_fr.properties.

Testing done

Proposed changelog entries

Translate hudson/model/Messages.properties and jenkins/model/Messages.properties into French.

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

lemeurherve

Small and mainly optional suggestions.

core/src/main/resources/jenkins/model/Messages_fr.properties

lemeurherve · 2023-10-08T09:06:56Z

ICYDK you can batch suggestions when you're on the "files" tab to commit them all at once.

Co-authored-by: Hervé Le Meur <[email protected]>

lemeurherve

I missed the main file as it wasn't displayed by default due to its large size ^^

lemeurherve · 2023-10-08T12:51:47Z

core/src/main/resources/hudson/model/Messages_fr.properties

+AbstractItem.BeingDeleted={0} en cours de suppression
+AbstractItem.FailureToStopBuilds=Echec de l''interruption et de l''arrêt de {0,choice,1#{0,number,integer} build|1<{0,number,integer} \
+  builds} de {1}
+AbstractItem.NewNameInUse=Le nom “{0}” est déjà utilisé.


Suggested change

AbstractItem.NewNameInUse=Le nom “{0}” est déjà utilisé.

AbstractItem.NewNameInUse=Le nom "{0}" est déjà utilisé.

Standard quotes

@lemeurherve
Mmmh, not sure about this one, as the default Messages.properties uses specific quotes.

I'm not sure why there are two sort of double quotes characters in the beginning, I think keeping only the standard ones would be better.

Question for the usual maintainers, what is the consensus (if any) about that?

Same about the use of special single quotes like L43 & L44 (‘{0}’) instead of double quotes?
Is it intentional or some sort of crust?

Note: these conversions could also be done in another PR, absolutely not blocking for this one.

core/src/main/resources/hudson/model/Messages_fr.properties

lemeurherve · 2023-10-08T13:12:47Z

core/src/main/resources/hudson/model/Messages_fr.properties

+Jenkins.CheckDisplayName.NameNotUniqueWarning=Le nom affiché, "{0}", est utilisé comme nom de job et peut causer des résultats de recherche erronés.
+Jenkins.CheckDisplayName.DisplayNameNotUniqueWarning=Le nom affiché, "{0}", est déjà utilisé par un autre job et peut engender des erreurs et des délais.
+
+Jenkins.NotAllowedName=“{0}” n''est pas un nom autorisé


Suggested change

Jenkins.NotAllowedName=“{0}” n''est pas un nom autorisé

Jenkins.NotAllowedName="{0}" n''est pas un nom autorisé

Standard quotes

Same here: https://github.com/jgreffe/jenkins/blob/2fc718da2a377d9dc411ebae95badf2f42212bef/core/src/main/resources/hudson/model/Messages.properties#L405

core/src/main/resources/hudson/model/Messages_fr.properties

lemeurherve

There are a few required changes in my last suggestions.

lemeurherve · 2023-10-08T17:01:29Z

NB: I think the tasklist rendering issue comes from the fact there isn't any space between the two squared brackets of its third item (- [] There is automated testing (...))

Co-authored-by: Hervé Le Meur <[email protected]>

lemeurherve

Great job by the way 👏

lemeurherve · 2023-10-08T18:10:10Z

core/src/main/resources/hudson/model/Messages_fr.properties

+AbstractItem.BeingDeleted={0} en cours de suppression
+AbstractItem.FailureToStopBuilds=Echec de l''interruption et de l''arrêt de {0,choice,1#{0,number,integer} build|1<{0,number,integer} \
+  builds} de {1}
+AbstractItem.NewNameInUse=Le nom “{0}” est déjà utilisé.


I'm not sure why there are two sort of double quotes characters in the beginning, I think keeping only the standard ones would be better.

Question for the usual maintainers, what is the consensus (if any) about that?

Same about the use of special single quotes like L43 & L44 (‘{0}’) instead of double quotes?
Is it intentional or some sort of crust?

Note: these conversions could also be done in another PR, absolutely not blocking for this one.

lemeurherve · 2023-10-08T18:14:43Z

core/src/main/resources/hudson/model/Messages_fr.properties

+Item.CONFIGURE.description=Modifie la configuration d''un job.
+Item.READ.description=Lire un job. (Vous pouvez interdire ce droit, mais autoriser Découvrir pour forcer un utilisateur anonyme à s''identifier et voir le job.)
+Item.RENAME.description=Renommer un job.
+ItemGroupMixIn.may_not_copy_as_it_contains_secrets_and_=Copie impossible de {0} car il contient des secrets et {1} possède {2}/{3} mais pas /{4}


Indeed, strange... I lack the context of this message to understand why it's that way, can anyone share it?

core/src/main/resources/hudson/model/Messages_fr.properties

Co-authored-by: Hervé Le Meur <[email protected]>

core/src/main/resources/hudson/model/Messages_fr.properties

Co-authored-by: Hervé Le Meur <[email protected]>

lemeurherve

LGTM, 🚢

welcome · 2023-10-10T17:35:20Z

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.

jgreffe added 2 commits October 7, 2023 23:16

[JENKINS-72141] French translation

73e4d09

[JENKINS-72141] French translation

a64c1bc

lemeurherve reviewed Oct 7, 2023

View reviewed changes

[JENKINS-72141] Apply suggestions

9798d9a

lemeurherve reviewed Oct 8, 2023

View reviewed changes

core/src/main/resources/jenkins/model/Messages_fr.properties Outdated Show resolved Hide resolved

Apply suggestions from code review

8f3ccab

Co-authored-by: Hervé Le Meur <[email protected]>

lemeurherve approved these changes Oct 8, 2023

View reviewed changes

NotMyFault added hacktoberfest-accepted localization labels Oct 8, 2023

NotMyFault approved these changes Oct 8, 2023

View reviewed changes

lemeurherve reviewed Oct 8, 2023

View reviewed changes

lemeurherve suggested changes Oct 8, 2023

View reviewed changes

Apply suggestions from code review

7833346

Co-authored-by: Hervé Le Meur <[email protected]>

jgreffe requested a review from lemeurherve October 8, 2023 17:54

lemeurherve approved these changes Oct 8, 2023

View reviewed changes

lemeurherve reviewed Oct 8, 2023

View reviewed changes

core/src/main/resources/hudson/model/Messages_fr.properties Outdated Show resolved Hide resolved

Apply suggestions from code review

e65a2ea

Co-authored-by: Hervé Le Meur <[email protected]>

jgreffe requested a review from lemeurherve October 9, 2023 05:49

lemeurherve approved these changes Oct 9, 2023

View reviewed changes

core/src/main/resources/hudson/model/Messages_fr.properties Outdated Show resolved Hide resolved

core/src/main/resources/hudson/model/Messages_fr.properties Outdated Show resolved Hide resolved

core/src/main/resources/hudson/model/Messages_fr.properties Outdated Show resolved Hide resolved

Apply suggestions from code review

df5ab45

Co-authored-by: Hervé Le Meur <[email protected]>

lemeurherve approved these changes Oct 9, 2023

View reviewed changes

Merge branch 'master' into JENKINS-72141_french-translation

87c062c

NotMyFault added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 9, 2023

NotMyFault merged commit f7bcc00 into jenkinsci:master Oct 10, 2023
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-72141] French translation #8577

[JENKINS-72141] French translation #8577

jgreffe commented Oct 7, 2023 •

edited by MarkEWaite

Loading

Submitter checklist

Maintainer checklist

lemeurherve left a comment

lemeurherve commented Oct 8, 2023

lemeurherve left a comment

lemeurherve Oct 8, 2023

jgreffe Oct 8, 2023

lemeurherve Oct 8, 2023

lemeurherve Oct 8, 2023

jgreffe Oct 8, 2023 •

edited

Loading

lemeurherve left a comment •

edited

Loading

lemeurherve commented Oct 8, 2023

lemeurherve left a comment

lemeurherve Oct 8, 2023

lemeurherve Oct 8, 2023

lemeurherve left a comment

welcome bot commented Oct 10, 2023

	AbstractItem.NewNameInUse=Le nom “{0}” est déjà utilisé.
	AbstractItem.NewNameInUse=Le nom "{0}" est déjà utilisé.

	Jenkins.NotAllowedName=“{0}” n''est pas un nom autorisé
	Jenkins.NotAllowedName="{0}" n''est pas un nom autorisé

[JENKINS-72141] French translation #8577

[JENKINS-72141] French translation #8577

Conversation

jgreffe commented Oct 7, 2023 • edited by MarkEWaite Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

lemeurherve left a comment

Choose a reason for hiding this comment

lemeurherve commented Oct 8, 2023

lemeurherve left a comment

Choose a reason for hiding this comment

lemeurherve Oct 8, 2023

Choose a reason for hiding this comment

jgreffe Oct 8, 2023

Choose a reason for hiding this comment

lemeurherve Oct 8, 2023

Choose a reason for hiding this comment

lemeurherve Oct 8, 2023

Choose a reason for hiding this comment

jgreffe Oct 8, 2023 • edited Loading

Choose a reason for hiding this comment

lemeurherve left a comment • edited Loading

Choose a reason for hiding this comment

lemeurherve commented Oct 8, 2023

lemeurherve left a comment

Choose a reason for hiding this comment

lemeurherve Oct 8, 2023

Choose a reason for hiding this comment

lemeurherve Oct 8, 2023

Choose a reason for hiding this comment

lemeurherve left a comment

Choose a reason for hiding this comment

welcome bot commented Oct 10, 2023

jgreffe commented Oct 7, 2023 •

edited by MarkEWaite

Loading

jgreffe Oct 8, 2023 •

edited

Loading

lemeurherve left a comment •

edited

Loading