Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note that general usage statistics submission is disabled with FIPS #8573

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

daniel-beck
Copy link
Member

Amends #8483 with the change suggested in #8483 (comment).

Unsure about wording, @jtnord WDYT?

Screenshot 2023-10-06 at 10 22 16

Testing done

Opened the form.

Proposed changelog entries

too minor

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@daniel-beck daniel-beck requested a review from jtnord October 6, 2023 08:38
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not think of any better wording

Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not think of any better wording

@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label Oct 6, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 6, 2023
@@ -24,6 +24,8 @@ statsBlurb=\
Help make Jenkins better by sending anonymous usage statistics and crash reports to the Jenkins project
statsBlurbFIPS=\
Help make Jenkins better by sending telemetry to the Jenkins project
statsDescriptionFIPS=\
General usage statistics are not submitted when FIPS-140 compliance is requested.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
General usage statistics are not submitted when FIPS-140 compliance is requested.
General usage statistics are never submitted when FIPS-140 compliance is requested.

To clarify it's independent of this setting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with either word, though I didn't infer the independence of the property from the change of wording. My reading treated those two words as synonyms in that context.

@MarkEWaite
Copy link
Contributor

Proceeding with the merge as currently phrased. We can rephrase in a later pull request if needed

@MarkEWaite MarkEWaite merged commit 9fd645a into jenkinsci:master Oct 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants