-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note that general usage statistics submission is disabled with FIPS #8573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not think of any better wording
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not think of any better wording
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. /label ready-for-merge |
@@ -24,6 +24,8 @@ statsBlurb=\ | |||
Help make Jenkins better by sending anonymous usage statistics and crash reports to the Jenkins project | |||
statsBlurbFIPS=\ | |||
Help make Jenkins better by sending telemetry to the Jenkins project | |||
statsDescriptionFIPS=\ | |||
General usage statistics are not submitted when FIPS-140 compliance is requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General usage statistics are not submitted when FIPS-140 compliance is requested. | |
General usage statistics are never submitted when FIPS-140 compliance is requested. |
To clarify it's independent of this setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with either word, though I didn't infer the independence of the property from the change of wording. My reading treated those two words as synonyms in that context.
Proceeding with the merge as currently phrased. We can rephrase in a later pull request if needed |
Amends #8483 with the change suggested in #8483 (comment).
Unsure about wording, @jtnord WDYT?
Testing done
Opened the form.
Proposed changelog entries
too minor
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist