Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72028] at test/src/test/java/jenkins/ replace deprecated URL() #8570

Merged
merged 13 commits into from
Oct 10, 2023

Conversation

abhishekmaity
Copy link
Contributor

@abhishekmaity abhishekmaity commented Oct 5, 2023

Replace deprecated URL() with URI#.toURL() . Changes implemented for test/src/test/java/jenkins/‎ files only.

See JENKINS-72028.

Testing done

Proposed changelog entries

  • JENKINS-X72028, replaced deprecated URL() with URI#.toURL()

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@abhishekmaity
Copy link
Contributor Author

/label java

@comment-ops-bot comment-ops-bot bot added the java Pull requests that update Java code label Oct 5, 2023
@abhishekmaity
Copy link
Contributor Author

/label hacktoberfest

@abhishekmaity
Copy link
Contributor Author

/label tests

@comment-ops-bot comment-ops-bot bot added the tests This PR adds/removes/updates test cases label Oct 5, 2023
@abhishekmaity
Copy link
Contributor Author

requesting @jtnord @timja @NotMyFault

@abhishekmaity
Copy link
Contributor Author

@jtnord I hope this is ready to merge PR

@jtnord
Copy link
Member

jtnord commented Oct 6, 2023

failure (jenkins.model.ScriptListenerTest.consoleUsageIsLogged) is #8574

@jtnord jtnord added the skip-changelog Should not be shown in the changelog label Oct 6, 2023
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NotMyFault NotMyFault added hacktoberfest-accepted and removed hacktoberfest java Pull requests that update Java code tests This PR adds/removes/updates test cases labels Oct 7, 2023
@NotMyFault
Copy link
Member

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 9, 2023
@NotMyFault NotMyFault merged commit 38a61a3 into jenkinsci:master Oct 10, 2023
16 checks passed
@abhishekmaity abhishekmaity deleted the url-dep-test-2 branch October 10, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants