Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72028] replace deprecated URL() at core/src/main/java/hudson/ #8565

Merged
merged 23 commits into from
Oct 11, 2023

Conversation

abhishekmaity
Copy link
Contributor

@abhishekmaity abhishekmaity commented Oct 4, 2023

Replace deprecated URL() with URI#.toURL() . Changes implemented for core/src/main/java/hudson/‎ files only.

See JENKINS-72028.

Testing done

Proposed changelog entries

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@abhishekmaity
Copy link
Contributor Author

/label java, hacktoberfest

@comment-ops-bot comment-ops-bot bot added the java Pull requests that update Java code label Oct 4, 2023
@comment-ops-bot
Copy link

I wasn't able to add the following labels: hacktoberfest

Check that the label exists and is spelt right then try again.

@abhishekmaity
Copy link
Contributor Author

/label hacktoberfest

@abhishekmaity abhishekmaity changed the title [JENKINS-72028] replace deprecated URL() [JENKINS-72028] replace deprecated URL() at core/src/main/java/hudson/ Oct 5, 2023
@abhishekmaity
Copy link
Contributor Author

requesting @jtnord @timja @NotMyFault

Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an occurence where the issue is silently swallowed, also please attempt to keep the diff to a minimum by not reformatting unchanged code.

@abhishekmaity abhishekmaity requested a review from jtnord October 6, 2023 17:43
@NotMyFault NotMyFault added skip-changelog Should not be shown in the changelog hacktoberfest-accepted and removed hacktoberfest labels Oct 7, 2023
@abhishekmaity
Copy link
Contributor Author

@jtnord I have replaced with e.getCause(); at core/src/main/java/hudson/cli/InstallPluginCommand.java now but its getting SpotBugs warning. Can you help to fix it.

@abhishekmaity abhishekmaity requested a review from jtnord October 9, 2023 16:16
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have accidently deleted a critical file (FilePath) and is changing things outside core/src/main/java/hudson/` (in the PR title and summary). Looks like a bad merge.

core/src/main/java/hudson/FilePath.java Show resolved Hide resolved
core/src/main/java/hudson/cli/InstallPluginCommand.java Outdated Show resolved Hide resolved
@abhishekmaity abhishekmaity requested a review from jtnord October 9, 2023 17:40
abhishekmaity and others added 2 commits October 10, 2023 19:14
@abhishekmaity abhishekmaity requested a review from jtnord October 10, 2023 13:45
@jtnord jtnord added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Oct 10, 2023
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming the build passes

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 10, 2023
@NotMyFault NotMyFault merged commit dc190ba into jenkinsci:master Oct 11, 2023
16 checks passed
@abhishekmaity abhishekmaity deleted the url-depreciation-1 branch October 12, 2023 15:03
@basil
Copy link
Member

basil commented Oct 18, 2023

Causes JENKINS-72203. In the absence of a tested fix, I intend to revert this PR toward 2.429.

basil added a commit that referenced this pull request Oct 23, 2023
basil added a commit that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants