-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-72028] replace deprecated URL()
at core/src/main/java/hudson/
#8565
[JENKINS-72028] replace deprecated URL()
at core/src/main/java/hudson/
#8565
Conversation
This reverts commit aeef4c1.
/label java, hacktoberfest |
I wasn't able to add the following labels: hacktoberfest Check that the label exists and is spelt right then try again. |
/label hacktoberfest |
URL()
URL()
at core/src/main/java/hudson/
requesting @jtnord @timja @NotMyFault |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is an occurence where the issue is silently swallowed, also please attempt to keep the diff to a minimum by not reformatting unchanged code.
@jtnord I have replaced with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to have accidently deleted a critical file (FilePath) and is changing things outside
core/src/main/java/hudson/` (in the PR title and summary). Looks like a bad merge.
Co-authored-by: James Nord <[email protected]>
remove non required as per suggestion Co-authored-by: James Nord <[email protected]>
Co-authored-by: James Nord <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming the build passes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!
Causes JENKINS-72203. In the absence of a tested fix, I intend to revert this PR toward 2.429. |
Replace deprecated
URL()
withURI
#.toURL()
. Changes implemented for core/src/main/java/hudson/ files only.See JENKINS-72028.
Testing done
Proposed changelog entries
URL()
withURI#.toURL()
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist