-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-71937] Fix deprecated Slave
constructor
#8564
Conversation
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. /label ready-for-merge |
Incremental build 2.427-rc34267.67cf93d3772c is available for testing. The incremental build is available from: https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-war/2.427-rc34267.67cf93d3772c/ @quacktacular Can you please test the incremental build and confirm the issue is resolved? |
@basil yes I'll take look shortly |
Looks good on my test env! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Testing Done section of the PR is blank, but a user has confirmed this PR resolves the issue.
This also fixes the issue in my test environment! |
[JENKINS-71937] Fix deprecated Slave constructor Got broken in jenkinsci#8395 Co-authored-by: Basil Crow <[email protected]> (cherry picked from commit 6fdfdd0)
Got broken in #8395
See JENKINS-71937.
Testing done
Issue reporter has confirmed that this fixes the issue that was experienced since Jenkins 2.421.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist