Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71937] Fix deprecated Slave constructor #8564

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Oct 4, 2023

Got broken in #8395

See JENKINS-71937.

Testing done

Issue reporter has confirmed that this fixes the issue that was experienced since Jenkins 2.421.

Proposed changelog entries

  • Fix agent allocation due to label issue detected by vSphere Cloud plugin (regression in 2.421).

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@Vlatombe Vlatombe requested a review from a team October 4, 2023 15:48
@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Oct 4, 2023
@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 4, 2023
@MarkEWaite MarkEWaite self-assigned this Oct 4, 2023
@basil
Copy link
Member

basil commented Oct 4, 2023

Incremental build 2.427-rc34267.67cf93d3772c is available for testing. The incremental build is available from: https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-war/2.427-rc34267.67cf93d3772c/

@quacktacular Can you please test the incremental build and confirm the issue is resolved?

@quacktacular
Copy link

@basil yes I'll take look shortly

@NotMyFault NotMyFault added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases and removed bug For changelog: Minor bug. Will be listed after features labels Oct 4, 2023
@quacktacular
Copy link

Looks good on my test env!

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Testing Done section of the PR is blank, but a user has confirmed this PR resolves the issue.

@bboehmke
Copy link

bboehmke commented Oct 5, 2023

This also fixes the issue in my test environment!

@MarkEWaite MarkEWaite merged commit 6fdfdd0 into jenkinsci:master Oct 6, 2023
16 checks passed
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Oct 29, 2023
[JENKINS-71937] Fix deprecated Slave constructor

Got broken in jenkinsci#8395

Co-authored-by: Basil Crow <[email protected]>

(cherry picked from commit 6fdfdd0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants