Tweak changelog entry placeholder #8532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-beck
approved these changes
Sep 28, 2023
NotMyFault
approved these changes
Sep 28, 2023
Yeah i'm a little worried about that, if I see it happening I'll remove it in a second iteration. |
Vlatombe
reviewed
Oct 2, 2023
| @@ -28,12 +28,15 @@ For refactoring and code cleanup changes, exercise the code before and after the | |||
|
|
|||
| ### Proposed changelog entries | |||
|
|
|||
| - Entry 1: Issue, human-readable text | |||
| - […] | |||
| - \<replace with Issue ID if it exists or remove\>, human-readable text | |||
There was a problem hiding this comment.
That pattern got me confused to be honest. I think giving an example would work better.
There was a problem hiding this comment.
Noting previously negative feedback I got in #7236 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(head branch, delete on merge)
I'm constantly removing
Entry 1:from entries, otherwise they end up in the changelog by accident...This should hopefully work better?