Add the 'alt' attribute to the logo in the README.md

[abhishekmaity]

missing 'alt' added to at README.md

[welcome]

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

[NotMyFault]

Thanks!

[abhishekmaity]

@NotMyFault Thank you

[MarkEWaite]

@abhishekmaity we prefer that the pull request description should match the content of the pull request and that the pull request should be submitted from a branch that is not the "master" branch. You can learn more about that process in the "Improve a plugin" tutorial.

We also prefer that the pull request checklist be completed and included in the pull request rather than being deleted. Since this pull request was a minor change to documentation, I didn't worry about requiring that you insert the full pull request template. Now that you've added significant changes and potentially incompatible changes, this pull request either needs to have those changes removed or it needs to be updated to use the pull request template

[MarkEWaite]

Changes are much broader than expected for the pull request description.

I've cleared the approval from @NotMyFault because the changes require a complete new review.

[NotMyFault]

I've cleared the approval from @NotMyFault because the changes require a complete new review.

Thanks for the PR, but as Mark mentioned, you will want to work with branches which aren't the master branch to create individual sets of PRs.

Additionally, this PR cannot be reviewed or merged in its current state. It appears you replaced all occurrences of new URL... with new URI... which doesn't work. While every URL can also be an URI, not every URI is an URL.
To address the issue, an understanding of URIs and URLs is needed.

[abhishekmaity]

@NotMyFault @MarkEWaite actually I have already reverted my last commit regarding URL thing as I discovered I was going totally wrong. I therefore re-request review the change now.

[abhishekmaity]

@abhishekmaity we prefer that the pull request description should match the content of the pull request and that the pull request should be submitted from a branch that is not the "master" branch. You can learn more about that process in the "Improve a plugin" tutorial.

We also prefer that the pull request checklist be completed and included in the pull request rather than being deleted. Since this pull request was a minor change to documentation, I didn't worry about requiring that you insert the full pull request template. Now that you've added significant changes and potentially incompatible changes, this pull request either needs to have those changes removed or it needs to be updated to use the pull request template

@jenkinsci/core-pr-reviewers I hope I have addressed the concerns raised by reviewers. I have already removed the significant and incompatible changes and I'm once again sorry for the mess I did to simple PR

[MarkEWaite]

Thanks!

[welcome]

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.