Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogRecorder programmatic deletion support #8489

Merged

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Sep 14, 2023

  • Add programmatic deletion support for LogRecorder. Previously this could only be done through a web request.
  • Also added event handling through SaveableListener whenever it gets deleted.

Testing done

Proposed changelog entries

  • Developer: Provide programmatic deletion support for LogRecorder.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

* Add programmatic deletion support for LogRecorder.
* Also added event handling through SaveableListener whenever it gets deleted.
@Vlatombe Vlatombe requested review from a team and jglick September 14, 2023 11:55
@timja timja added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted developer Changes which impact plugin developers and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Sep 14, 2023
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 14, 2023
@NotMyFault NotMyFault merged commit 7d28571 into jenkinsci:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants