Remove finalization from RegistryKey
#8488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of Java have deprecated
Object#finalize
and marked it for removal. In this PR we are removing finalization fromRegistryKey
, which already implemented explicit termination viaAutoCloseable
. Unlike #8486, there were only a handful of usages throughout the ecosystem (I checked thecloudbees
GitHub organization as well), and I audited each and every one to ensure it was already using the explicit terminator, either via try-with-resources or try-finally. Furthermore, all usages outside core were in extremely ancient plugins that are not relevant anymore. For core itself, SpotBugs would warn us if we introduced a new resource leak by forgetting to use try-with-resources. Weighing all of this against the complexity of reimplementing this (untested) functionality with theCleaner
API, it seemed best to simply dispense with this unused fallback mechanism rather than to port it to Java 9+.Testing done
mvn clean verify -DskipTests
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist