Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent scrolling for textarea preview #8472

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Sep 8, 2023

Prevent that when clicking on preview for a textarea, the page scrolls to the top and the url changes.

Testing done

Jenkins with OWASP markupformatter enabled
Go to configure of a job, scroll a bit down enter html in the description and then press on preview.
The page will no longer scroll to the top and change the url

Proposed changelog entries

  • Entry 1: prevent scrolling for textarea preview
  • […]

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Prevent that when clicking on preview for a textarea, the page scrolls
to the top and the url changed.
@mawinter69 mawinter69 changed the title prevent scrolling for preview prevent scrolling for textarea preview Sep 8, 2023
@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Sep 9, 2023
@NotMyFault NotMyFault requested a review from a team September 9, 2023 08:23
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 9, 2023
@NotMyFault NotMyFault changed the title prevent scrolling for textarea preview Prevent scrolling for textarea preview Sep 10, 2023
@NotMyFault NotMyFault merged commit 6b00394 into jenkinsci:master Sep 10, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants