-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry for security-related settings #8440
Add telemetry for security-related settings #8440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but SpotBugs.
Agreed with @NotMyFault that the change looks good but the spotbugs warning needs to be resolved or suppressed before this can be merged |
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. |
Should this be included in 2.414.2 and .3 too? I'm not too familiar with which versions metrics shall be collected from. |
Including this in the backporting for |
* Add telemetry for security-related settings * Actually include component information * FindBugs, also TcpSlaveAgentListener can be null --------- Co-authored-by: Daniel Beck <[email protected]> (cherry picked from commit 95373a9)
What it says in the title.
Help UI rendered:
Testing done
Checked the help text of the usage stats option (see screenshot)
Confirmed that the output of
ExtensionList.lookupSingleton(jenkins.telemetry.impl.SecurityConfiguration).createContent()
makes sense:Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist