Update appearance of keyboard shortcut tooltips #8435

janfaracik · 2023-08-25T20:31:35Z

Small one in preparation for #7569. This PR adds a new component for showing keyboard shortcuts, it's currently used in the tooltip for search bars.

Screen.Recording.2023-08-25.at.21.29.41.mov

This will be used for the Command Palette button too, where hovering over the Search icon will list what shortcuts activate it.

Testing done

Shortcut and animation display as expected

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

timja

works nicely

Kevin-CB

Looks fine from a security perspective!

timja · 2023-08-29T07:59:04Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

daniel-beck

Is there a way to demonstrate the CMD/CTRL behavior? Right now it's unused code.

core/src/main/resources/lib/layout/keyboard-shortcut.jelly

core/src/main/java/hudson/Functions.java

daniel-beck · 2023-08-29T12:30:17Z

core/src/main/resources/lib/layout/keyboard-shortcut.jelly

+  </st:documentation>
+
+  <div class="jenkins-tooltip__keyboard-shortcut">
+    <j:if test="${attrs.prefix != null}">


It does not seem to be possible to define empty localizations. An attempt to do so will just use the default locale:

Good spot - updated.

daniel-beck · 2023-08-29T12:32:39Z

Subjective design feedback: The animation doesn't look good at the actual size. I first thought it was a bug, in particular on the default (non-dark) theme.

weird.animation.firefox.mov

daniel-beck

Still doesn't work for me.

(The build claims to be 2.434-SNAPSHOT so I'm not running the old one.)

Did you test this before resubmitting for review? If you did, what does the localized file look like?

timja · 2023-12-16T21:50:17Z

Still doesn't work for me. (The build claims to be 2.434-SNAPSHOT so I'm not running the old one.)

Did you test this before resubmitting for review? If you did, what does the localized file look like?

Works fine for me, there's a prefix and a suffix you need to update, I just fixed up a localisation (e.g. pl) as an example.

core/src/main/java/hudson/Functions.java

janfaracik · 2024-08-04T14:56:12Z

@daniel-beck @timja Updated this - big thanks to both of you for the comments and assistance.

core/src/main/java/hudson/Functions.java

timja

LGTM - tested the latest changes and reviewed the code, much more in line with what was expected and cleaner, thanks. Apologies for the delay

addressed

timja · 2024-10-06T15:54:46Z

Re-requested @NotMyFault review as the code has changed a fair bit since last approved.

@daniel-beck do you have an ETA / plan to review again?

Thanks

github-actions · 2024-10-12T18:48:40Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

timja · 2024-10-13T10:37:22Z

cc @NotMyFault ^^

krisstern

Makes sense to me

krisstern · 2024-12-07T12:44:14Z

@daniel-beck Would you like to review again?

c.c. @NotMyFault

timja · 2024-12-07T14:12:37Z

@daniel-beck Would you like to review again?

been 4 months since the original request for another review time to move on unless @daniel-beck you're able to make a commitment to review?

In the meantime:

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

janfaracik and others added 2 commits August 23, 2023 21:35

Init

0d8e1a2

yarn lint:fix

1783029

timja added the skip-changelog Should not be shown in the changelog label Aug 26, 2023

timja approved these changes Aug 26, 2023

View reviewed changes

timja requested a review from a team August 26, 2023 07:40

timja added the needs-security-review Awaiting review by a security team member label Aug 26, 2023

timja requested a review from a team August 26, 2023 07:40

NotMyFault approved these changes Aug 28, 2023

View reviewed changes

Kevin-CB approved these changes Aug 29, 2023

View reviewed changes

Kevin-CB added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Aug 29, 2023

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 29, 2023

daniel-beck requested changes Aug 29, 2023

View reviewed changes

core/src/main/resources/lib/layout/keyboard-shortcut.jelly Outdated Show resolved Hide resolved

core/src/main/java/hudson/Functions.java Show resolved Hide resolved

daniel-beck requested changes Aug 29, 2023

View reviewed changes

daniel-beck removed the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 29, 2023

janfaracik added 3 commits November 5, 2023 20:08

Merge branch 'master' into keyboard-shortcut-animation

ec58717

Merge branch 'master' into keyboard-shortcut-animation

231631d

Address comments

3996dc0

timja requested a review from daniel-beck November 23, 2023 16:14

Merge branch 'master' into keyboard-shortcut-animation

95be904

daniel-beck requested changes Dec 6, 2023

View reviewed changes

timja added the web-ui The PR includes WebUI changes which may need special expertise label Dec 16, 2023

Update localisation

8c2ef1a

timja requested a review from daniel-beck December 16, 2023 21:50

Merge branch 'master' into keyboard-shortcut-animation

b5d4170

timja reviewed Dec 17, 2023

View reviewed changes

core/src/main/java/hudson/Functions.java Outdated Show resolved Hide resolved

Update core/src/main/java/hudson/Functions.java

ce09ad8

timja and others added 4 commits May 29, 2024 21:29

Add english default message

b0d87b9

More detailed wording for message attribute

02a8466

Merge branch 'master' into keyboard-shortcut-animation

ae0685a

Update keyboard shortcut component

08c24de

MarkEWaite requested review from daniel-beck and timja September 11, 2024 15:11

janfaracik added 2 commits September 13, 2024 08:54

Merge branch 'master' into keyboard-shortcut-animation

f9fad99

Merge branch 'master' into keyboard-shortcut-animation

08a248c

timja reviewed Sep 16, 2024

View reviewed changes

core/src/main/java/hudson/Functions.java Outdated Show resolved Hide resolved

timja and others added 2 commits September 16, 2024 14:15

Update core/src/main/java/hudson/Functions.java

f3913dd

Adapt for Java EE upgrade

b893717

timja approved these changes Oct 6, 2024

View reviewed changes

timja requested a review from NotMyFault October 6, 2024 15:54

github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Oct 12, 2024

Merge branch 'master' into keyboard-shortcut-animation

34f77dd

github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Oct 12, 2024

timja requested a review from a team October 15, 2024 18:48

timja requested review from mawinter69 and a team November 1, 2024 16:45

krisstern approved these changes Dec 7, 2024

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 7, 2024

krisstern merged commit d046516 into jenkinsci:master Dec 8, 2024
16 checks passed

janfaracik deleted the keyboard-shortcut-animation branch December 8, 2024 15:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update appearance of keyboard shortcut tooltips #8435

Update appearance of keyboard shortcut tooltips #8435

janfaracik commented Aug 25, 2023 •

edited by krisstern

Loading

Submitter checklist

Maintainer checklist

timja left a comment

Kevin-CB left a comment

timja commented Aug 29, 2023

daniel-beck left a comment

daniel-beck Aug 29, 2023

janfaracik Nov 20, 2023

daniel-beck commented Aug 29, 2023

daniel-beck left a comment

timja commented Dec 16, 2023 •

edited

Loading

janfaracik commented Aug 4, 2024

timja left a comment

timja commented Oct 6, 2024

github-actions bot commented Oct 12, 2024

timja commented Oct 13, 2024

krisstern left a comment

krisstern commented Dec 7, 2024

timja commented Dec 7, 2024

Update appearance of keyboard shortcut tooltips #8435

Update appearance of keyboard shortcut tooltips #8435

Conversation

janfaracik commented Aug 25, 2023 • edited by krisstern Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

timja left a comment

Choose a reason for hiding this comment

Kevin-CB left a comment

Choose a reason for hiding this comment

timja commented Aug 29, 2023

daniel-beck left a comment

Choose a reason for hiding this comment

daniel-beck Aug 29, 2023

Choose a reason for hiding this comment

janfaracik Nov 20, 2023

Choose a reason for hiding this comment

daniel-beck commented Aug 29, 2023

daniel-beck left a comment

Choose a reason for hiding this comment

timja commented Dec 16, 2023 • edited Loading

janfaracik commented Aug 4, 2024

timja left a comment

Choose a reason for hiding this comment

timja commented Oct 6, 2024

github-actions bot commented Oct 12, 2024

timja commented Oct 13, 2024

krisstern left a comment

Choose a reason for hiding this comment

krisstern commented Dec 7, 2024

timja commented Dec 7, 2024

janfaracik commented Aug 25, 2023 •

edited by krisstern

Loading

timja commented Dec 16, 2023 •

edited

Loading