Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71252][JENKINS-70793] Multiple form validation fixes #8422

Merged
merged 2 commits into from
Oct 5, 2023
Merged

[JENKINS-71252][JENKINS-70793] Multiple form validation fixes #8422

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b11ed8b
[JENKINS-71252] Show form validation for hidden elements
daniel-beck Aug 23, 2023
8f60bfb
[JENKINS-70793] Clear all validation output on update
daniel-beck Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions war/src/main/webapp/scripts/hudson-behavior.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,17 +634,7 @@ function updateValidationArea(validationArea, content) {
// Only change content if different, causes an unnecessary animation otherwise
if (validationArea.innerHTML !== content) {
validationArea.innerHTML = content;
validationArea.style.height =
validationArea.children[0].offsetHeight + "px";

// Only include the notice in the validation-error-area, move all other elements out
if (validationArea.children.length > 1) {
Array.from(validationArea.children)
.slice(1)
.forEach((element) => {
validationArea.after(element);
});
}
validationArea.style.height = "auto";

Behaviour.applySubtree(validationArea);
// For errors with additional details, apply the subtree to the expandable details pane
Copy link
Member Author

@daniel-beck daniel-beck Aug 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line and following are probably obsolete now and can be deleted?

Expand Down