Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side-port test cleanup from jenkinsci/remoting#587 #8414

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

basil
Copy link
Member

@basil basil commented Aug 22, 2023

In jenkinsci/remoting#587 @offa applied some valuable test cleanup to RegexValidatorTest, but this cleanup was never applied to the copy of this test in Jenkins core.

Testing done

Ran the affected test locally.

Proposed changelog entries

  • Entry 1: Issue, human-readable text
  • […]

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added the skip-changelog Should not be shown in the changelog label Aug 22, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@NotMyFault NotMyFault merged commit 6e39c5b into jenkinsci:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants