draft: JENKINS-71527 - Update CodeMirror to v6

[janfaracik]

See JENKINS-71527.

Jenkins relies on https://github.com/stapler/stapler-adjunct-codemirror to utilize code mirror.
This library is almost 10 years out of date and ships an ancient version of codemirror 2 (6 is the newest while writing this). Upgrading to v6 allows us to stop our usages of the above library as well as make use of all the new features in CodeMirror since then. There's now autocomplete, better accessibility, colours now use Jenkins variables and a whole load of other changes in the last ten years.

Draft as there's a lot of questions around this/work to do.

1. With it being a large upgrade, I'm unsure if the textarea parameter codemirror-config will work the same way as before. What's the best option to handle this?
2. The Pipeline plugin uses Ace - is there a reason for deviating from Jenkins, is there potential to settle on one library?

Things to do

• Ensure compatibility with existing usages
• Add resizing
• Ensure readonly mode works

Testing done

• Not done yet

Proposed changelog entries

• Upgrade CodeMirror from 2.38 to v6.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

Interesting comparison:
https://blog.replit.com/code-editors

I don't see a reason we need two, I assume codemirror was missing features at the time.

[timja]

script console size should start larger

[janfaracik]

script console size should start larger

Just for script console or for all CodeMirror editors?

[timja]

script console size should start larger

Just for script console or for all CodeMirror editors?

probably all

[timja]

run button is touching the script console textarea where before there was spacing

I think it could do with a larger minHeight too
see before:

[timja]

Not a blocker but I think the theme the dark-theme is using is easier to read on code mirror 4:

This PR:

Master with dark-theme:

From this gist: https://gist.githubusercontent.com/timja/04afb12c8ad909e400317a2ad9c88445/raw/7a9433120150425d3e944074227c215dcce81181/jenkins-dump-credentials.groovy

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[daniel-beck]

Given the title, is this supposed to be in the draft state?

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[timja]

this doesn't seem to be working, at least for shell steps on freestyle builds.

It gets called but the new value isn't submitted.
Also doesn't get called at all on Apply button clicks

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[janfaracik]

Will come back to this.