Upgrade to winstone with Jetty 12

[olamy]

Signed-off-by: Olivier Lamy [email protected]

See JENKINS-XXXXX.

Testing done

Proposed changelog entries

• Entry 1: Issue, human-readable text
• […]

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[basil]

Incomplete—does not include the requisite WebSocket changes for Jetty 12.

[basil]

WebSocket test automation fails.

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[basil]

Not only that, but the test harness needs significant changes for Jetty 12, along with these tests:

test/src/test/java/hudson/model/QueueTest.java
test/src/test/java/hudson/model/UpdateSiteTest.java
test/src/test/java/jenkins/install/SetupWizardTest.java
test/src/test/java/jenkins/util/SystemPropertiesTest.java

[basil]

Still failing WebSocket RealJenkinsRule tests, presumably due to websocket-jetty12-ee8 being missing from war/pom.xml.

[basil]

When upgrading Jetty to version 12 in Jenkins core, I think the core test suite should also be adapted to Jetty 12. Any progress on resolving the three known Jetty 12 test bugs in the core test suite? These are tracked in Jira:

• JENKINS-73127
• JENKINS-73128
• JENKINS-73129

[olamy]

As I have giving up with jenkinsci/winstone#341 I close this PR as well.
Everybody is free to reuse the branch from the fork