-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: Use a sidebar for Manage Jenkins #8379
draft: Use a sidebar for Manage Jenkins #8379
Conversation
@@ -134,3 +137,14 @@ $background-outset: 0.7rem; | |||
} | |||
} | |||
} | |||
|
|||
.nodeswidgetview { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placeholder class for the time being - this needs to be replaced.
@@ -28,17 +28,23 @@ THE SOFTWARE. | |||
<?jelly escape-by-default='true'?> | |||
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:s="/lib/form"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire page still needs work
@@ -24,8 +24,10 @@ THE SOFTWARE. | |||
|
|||
<!-- About Jenkins page --> | |||
<?jelly escape-by-default='true'?> | |||
<j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout" xmlns:t="/lib/hudson"> | |||
<l:layout type="one-column" permissions="${app.MANAGE_AND_SYSTEM_READ}" title="${%about(app.VERSION)}"> | |||
<j:jelly xmlns:st="jelly:stapler" xmlns:j="jelly:core" xmlns:l="/lib/layout" xmlns:t="/lib/hudson"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth having a new component (e.g. SettingsItemLayout.jelly) rather than layout.jelly
to wrap pages?
Are what you listed the only benefits of this? They seem fairly minor in comparison to the drawbacks: This
In particular, I don't see how
applies other than at the most superficial level. Job configurations navigate inside the same form, while here, everything navigates elsewhere, dropping unsaved changes. This mirrors a similar change in Mac OS System Preferences to make it more iPhone-like, which I've only seen overwhelmingly negative feedback for. Replicating phone UI when you have giant screens makes no sense. Beyond the above, I'm curious what your plans for the sidepanel of the plugin manager are. Given we've moved items from elsewhere to there less than a year ago, with further related changes in a PR (#8376, open when I commented and now merged), that seems to clash with this proposal quite significantly. |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Will write a proposal for this and come back to it - thanks all. |
Draft PR for the time being.
This PR overhauls Manage Jenkins to use a sidebar for links, rather than the current grid view. This was discussed on https://community.jenkins.io/t/new-settings-view-feedback-wanted/ and I've opened a draft PR to get further thoughts on implementation and to highlight things that I've missed.
The advantages to this design:
Screenshots
This will require updates to plugins to implement the ManagementLink side panel.
Testing done
Todo
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist