Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports of Prototype fixes from 2.417 to stable-2.414 #8345

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

basil
Copy link
Member

@basil basil commented Aug 7, 2023

This PR contains backports of #8280, #8279, #8278, and #8307 (all delivered one week ago in 2.417) to stable-2.414. The reason for this proposal is to make 2.414.1 a solid LTS baseline for plugins to depend on in the post-Prototype transition, with all known Prototype fixes integrated to core. While the four mentioned PRs are code cleanup PRs rather than bug fixes, I think it is worth backporting them so that plugins that require a recent LTS baseline (e.g. for #8008) have one they can depend on that is consistent with weeklies. There are no reported regressions with the above 4 PRs.

Testing done

None, other than the PR build for this PR.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added the into-lts This PR is filed against an LTS branch label Aug 7, 2023
@basil basil requested a review from a team August 7, 2023 19:57
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right change. We want the Prototype.js code consistent between weekly and LTS

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@NotMyFault NotMyFault merged commit 213ba8c into jenkinsci:stable-2.414 Aug 8, 2023
@basil basil deleted the prototype branch August 8, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
into-lts This PR is filed against an LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants