[JENKINS-71737] Fix redirect when submitting cloud changes

core/src/main/java/hudson/slaves/Cloud.java

@@ -330,8 +330,8 @@ public HttpResponse doConfigSubmit(StaplerRequest req, StaplerResponse rsp) thro
         }
         j.clouds.replace(this, result);
         j.save();
-        // take the user back to the cloud top page.
-        return FormApply.success(".");
+        // take the user back to the root clouds page.
+        return FormApply.success("..");
     }
 
     public Cloud reconfigure(@NonNull final StaplerRequest req, JSONObject form) throws Descriptor.FormException {

test/src/test/java/hudson/slaves/CloudTest.java

@@ -11,6 +11,7 @@
 import edu.umd.cs.findbugs.annotations.NonNull;
 import hudson.model.Action;
 import hudson.model.Computer;
+import hudson.model.Descriptor;
 import hudson.model.Label;
 import hudson.security.Permission;
 import hudson.security.SidACL;
@@ -21,13 +22,16 @@
 import jenkins.model.Jenkins;
 import jenkins.model.TransientActionFactory;
 import org.acegisecurity.acls.sid.Sid;
+import org.htmlunit.html.HtmlForm;
 import org.htmlunit.html.HtmlPage;
+import org.htmlunit.html.HtmlTextInput;
 import org.junit.Rule;
 import org.junit.Test;
 import org.jvnet.hudson.test.Issue;
 import org.jvnet.hudson.test.JenkinsRule;
 import org.jvnet.hudson.test.TestExtension;
 import org.jvnet.hudson.test.WithoutJenkins;
+import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.StaplerResponse;
 
 public class CloudTest {
@@ -85,9 +89,22 @@ public void cloudNameIsEncodedInGetUrl() {
         assertEquals("Cloud name is encoded in Cloud#getUrl", "cloud/..%2F..%2Fgibberish/", aCloud.getUrl());
     }
 
+    @Test
+    public void changeCloudName() throws Exception {
+        ACloud aCloud = new ACloud("a", "0");
+        j.jenkins.clouds.add(aCloud);
+        HtmlForm form = j.createWebClient().goTo(aCloud.getUrl() + "configure").getFormByName("config");
+        HtmlTextInput input = form.getInputByName("_.name");
+        input.setText("b");
+        j.submit(form);
+        ACloud actual = j.jenkins.clouds.get(ACloud.class);
+        assertEquals("b", actual.getDisplayName());
+    }
+
     public static final class ACloud extends AbstractCloudImpl {
 
-        protected ACloud(String name, String instanceCapStr) {
+        @DataBoundConstructor
+        public ACloud(String name, String instanceCapStr) {
             super(name, instanceCapStr);
         }
 
@@ -98,6 +115,10 @@ protected ACloud(String name, String instanceCapStr) {
         @Override public boolean canProvision(Label label) {
             return false;
         }
+
+        @TestExtension
+        public static class DescriptorImpl extends Descriptor<Cloud> {
+        }
     }
 
     @TestExtension

test/src/test/resources/hudson/slaves/CloudTest/ACloud/config.jelly

@@ -0,0 +1,6 @@
+<?jelly escape-by-default='true'?>
+<j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form">
+  <f:entry title="${%Name}" field="name">
+    <f:textbox />
+  </f:entry>
+</j:jelly>