allow string for badge attribute of l:task #8260
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation can be interpreted that the badge attribute accepts a String as argument. But in reality it requires an instance of jenkins.management.Badge
The effect can be seen on the Design Library
https://weekly.ci.jenkins.io/design-library/Layouts/twoColumn
Where a String is passed but is not shown.
This change allows either a Badge object or something else which is then just printed.
Testing done
I tested this by modifying the sidepanel of the ComputerSet page
<l:task href="${h.getNearestAncestorUrl(request,it)}/" icon="symbol-computer"
title="${%Nodes}" badge="${it._all.size()}"/>
The page then properly show me the number of agents (without having a tooltip)
On the plugins page the number of updates is still shown with a tooltip.
Before:

After:

Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).