-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-70805] Remove !important
from styles in <pre>
#7836
Conversation
Jenkins should allow plugins to change the fonts in themes or plugins that render preformatted text.
Originally added in @janfaracik's #6259 without explanation. |
Looking good. Only regression that I've found is the CodeMirror textarea on Script Console no longer has the correct font. I haven't tried but looks like that could be fixed by applying the properties to
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
Jenkins should allow plugins to change the fonts in themes or plugins that render pre-formatted text. I'm not sure why the
important!
suffix has been added here but the console view still renders fine when this suffix will be removed.For more details please see JENKINS-70805.
Console View Before (Left), After (Right) [Both are identical]:
Source Code View with Prism Plugin Before (Left), After (Right) [Right is fixed, left is broken]:
Testing done
Manual testing by inspecting the console log view and the source code view of the warnings plugin.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@timja
@janfaracik
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).