-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-70169] Add missing breadcrumb items in various resources/hudson
locations
#7496
Merged
NotMyFault
merged 7 commits into
jenkinsci:master
from
lemeurherve:JENKINS-70169-breadcrumb-resources-hudson-various
Jan 14, 2023
Merged
[JENKINS-70169] Add missing breadcrumb items in various resources/hudson
locations
#7496
NotMyFault
merged 7 commits into
jenkinsci:master
from
lemeurherve:JENKINS-70169-breadcrumb-resources-hudson-various
Jan 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
added
web-ui
The PR includes WebUI changes which may need special expertise
rfe
For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
labels
Dec 7, 2022
NotMyFault
approved these changes
Dec 28, 2022
timja
reviewed
Dec 29, 2022
core/src/main/resources/hudson/model/labels/LabelAtom/configure.jelly
Outdated
Show resolved
Hide resolved
timja
added
the
needs-comments-resolved
Comments in the PR need to be addressed before it can be considered for merging
label
Dec 30, 2022
Co-authored-by: Tim Jacomb <[email protected]>
NotMyFault
removed
the
needs-comments-resolved
Comments in the PR need to be addressed before it can be considered for merging
label
Jan 13, 2023
timja
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
comment-ops-bot
bot
added
the
ready-for-merge
The PR is ready to go, and it will be merged soon if there is no negative feedback
label
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-for-merge
The PR is ready to go, and it will be merged soon if there is no negative feedback
rfe
For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
web-ui
The PR includes WebUI changes which may need special expertise
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract from #7457 (remaining from the other PRs, too few on each folder to merit its own PR)
Follow-up of #6912
Initially fixing JENKINS-70169, I've included every missing breadcrumb items I've found by searching for "sidepanel.jelly" in jelly files.
Notes:
I've added
<!-- no need for breadcrumb here -->
as comment in views where adding a breadcrumb item wasn't necessary, let me know if it's preferable to omit them.This doesn't fix missing breadcrumb depending on plugin (ex: Add missing breadcrumbs to job configuration cloudbees-folder-plugin#278)
Testing done
Built and ran Jenkins locally, going on modified pages to check the change.
There is no additional automatic test added for these breadcrumb items.
With a job "test",
http://localhost:8080/jenkins/job/test/ws/
:http://localhost:8080/jenkins/job/test/buildTimeTrend
:http://localhost:8080/jenkins/user/test/my-views/newView
:http://localhost:8080/jenkins/signup/
,Before, no link on "Dashboard", and no side panel:
After:
I'm not sure where to find the following corresponding changes (thus untested and potentially not wanted):
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).