[JENKINS-70178] Improve tooltip performance

[janfaracik]

See JENKINS-70178.

Thanks to those that reported it, with this fix you should see major improvements in rendering tooltips. The issue was caused due a misunderstanding in how behavior.specify works, I thought specify would only be triggered the once and thus render all tooltips once, instead it rendered all tooltips each time the specify was triggered.

Testing done

I added roughly two hundred buttons to a page with tooltips set, pre-fix this page had a long stall, post-fix the page is essentially instant.

Proposed changelog entries

• [JENKINS-70178] Improve tooltip performance

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
  • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[sentient]

Thanks for the quick fix.
I witnessed the same at the role-strategy plugin that renders pop overs on every checkbox.

[timja]

Thanks for the quick fix. I witnessed the same at the role-strategy plugin that renders pop overs on every checkbox.

Did you want to test that this fixes your issue?

[sentient]

@timja I can do that. What would be my steps to get this deployed?

[daniel-beck]

docker run --rm -ti -p 8080:8080 -e ID=7464 -e MERGE_WITH=master jenkins/core-pr-tester

[sentient]

@timja it worked for me.
I verified the role-strategy plugin (after spinning up the docker image. Thanks @daniel-beck )

[Kevin-CB]

Looks good from a security aspect

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!