Enable word breaking for job names

[olivergondza]

Fix for JENKINS-17030.

This implementation inserts "break-marks" explicitly as I was not able to come up with purely CSS solution. AFAIK, word-wrap and break-word works only for elements having explicitly declared width.

Whether to use <wbr>, ­ or some other alternative is a subject of discussion.

[cloudbees-pull-request-builder]

core » jenkins_main_trunk #693 UNSTABLE
Looks like there's a problem with this pull request

[buildhive]

Jenkins » jenkins #28 ABORTED

(what's this?)

[cloudbees-pull-request-builder]

core » jenkins_main_trunk #799 FAILURE
Looks like there's a problem with this pull request

[jglick]

Missing a ; here I think.

[jglick]

http://stackoverflow.com/questions/226464/soft-hyphen-in-html-wbr-vs-shy seems inconclusive. The wbr tag makes sense to me, but remember that Jelly output is X(HT)ML whereas you seem to be emitting HTML.

[olivergondza]

Thank you for the review. You are right about the HTML. Using ​ entity instead of <wbr> seems valid and working in modern browsers and as a numbered entity, it should not cause problems with XML.

I will update the pull request accordingly.

[cloudbees-pull-request-builder]

core » jenkins_main_trunk #803 UNSTABLE
Looks like there's a problem with this pull request

[jglick]

Rather than emit ​ why not emit the actual Unicode character (\u200b) and avoid any possible issues with metacharacters?

In which case there would be no reason for clients to escape anything; and breakable.jelly would be overkill: you could just write e.g.

<h1>${it.pronoun} ${h.breakableString(it.displayName)}</h1>

(This is all assuming that ZWSP is in fact a good replacement for <wbr>. SHY looks a bit better according to this page but seems less compatible.)

[olivergondza]

It does look better, but can we assume we serve unicode? I will test it and create new PR, this one is cluttered.

[vjuranek]

yes, we assume unicode:
https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/lib/layout/layout.jelly#L59

[jglick]

Emitting the raw Unicode character should be fine.

By the way you should look into using soft breaking in core/src/main/resources/lib/hudson/propertyTable.jelly, e.g. <st:out value="${h.breakableString(e.value)}"/>. It is sorely needed for things like ${sun.boot.class.path} and $CATALINA_OPTS in /systemInfo. Demonstration:

"LONG_ENV=lots and lots of text here" mvn -f war/pom.xml -DskipTests=true "-Dlongsysprop=lots more text here" hudson-dev:run

[olivergondza]

Here is what I found, after a bit of experimenting with Unicode characters:

\u200b - Breaks page search
\u00ad - Unicode equivalent of ­. It does what we want

http://jsfiddle.net/qY6mp/4/

[olivergondza]

to @jglick : String containing \u00ad are copied with this characters (in firefox and chromium but not in Opera). This might be problematic for things like classpaths.

Sadly, I did not manage to find Unicode char that would allow line break, be ignored while searching and not appear in copied text. Not to mention we want this to work cross-browser.

[jglick]

In that case we are back to <wbr/> I guess. It seems to be supported in most browsers. The only downside I see is that it does not display a hyphen glyph indicating that the line was broken, but you could probably guess this anyway.

[olivergondza]

I guess so. Unfortunately, this bring the ugly breakable.jelly back too.

[jglick]

Right, because ${…} will be escaped. Still, if it works then this does not seem too bad, assuming there is not a long list of places where it needs to be used.

[olivergondza]

Replaced by #767