Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook to run frontend linters #7075

Closed
wants to merge 7 commits into from
Closed

Add pre-commit hook to run frontend linters #7075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cd0bb84
Add pre-commit to run frontend linters
timja Sep 7, 2022
16a09ea
Use fixed versions
timja Sep 8, 2022
3c833d3
Add json to prettier
timja Sep 8, 2022
a7caaa8
Merge branch 'master' into add-lint-staged-and-husky
timja Sep 8, 2022
13133c4
Merge branch 'master' into add-lint-staged-and-husky
timja Sep 10, 2022
6445262
Merge branch 'master' into add-lint-staged-and-husky
timja Sep 14, 2022
78a5148
Update war/.husky/pre-commit
timja Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions war/.husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/usr/bin/env sh
# https://typicode.github.io/husky/
. "$(dirname -- "$0")/_/husky.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally despite the shell script, it's supported on Windows (https://typicode.github.io/husky/#/?id=does-it-work-on-windows)
Now, it could be interesting to get some Windows users to ensure it's really working.
On my own system it was working, but perhaps I have too many stuff installed that are necessary for Jenkins development.

timja marked this conversation as resolved.
Show resolved Hide resolved

cd war || exit 1
yarn lint-staged
12 changes: 10 additions & 2 deletions war/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"lint:css-ci": "stylelint src/main/less --custom-formatter stylelint-formatter.js -o target/stylelint-warnings.xml",
"lint:ci": "yarn lint:js-ci && yarn lint:css-ci",
"lint:fix": "prettier --write ../ && stylelint src/main/less --fix && eslint --config .eslintrc.js --fix ../",
"lint": "yarn lint:js && yarn lint:css"
"lint": "yarn lint:js && yarn lint:css",
"postinstall": "cd .. && husky install war/.husky"
},
"devDependencies": {
"@babel/cli": "7.18.10",
Expand All @@ -34,8 +35,10 @@
"eslint-config-prettier": "8.5.0",
"handlebars": "4.7.7",
"handlebars-loader": "1.7.2",
"husky": "8.0.1",
"less": "4.1.3",
"less-loader": "11.0.0",
"lint-staged": "13.0.3",
"mini-css-extract-plugin": "2.6.1",
"postcss": "8.4.16",
"postcss-loader": "7.0.1",
Expand Down Expand Up @@ -64,5 +67,10 @@
"defaults",
"not IE 11"
],
"packageManager": "[email protected]"
"packageManager": "[email protected]",
"lint-staged": {
"*.{html,css,less,md,js,json}": "prettier --write",
"*.js": "eslint --fix",
"*.{less,css}": "stylelint --fix"
}
}
Loading