Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore git-blame for prettier reformat #7035

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

timja
Copy link
Member

@timja timja commented Aug 25, 2022

see #6863

@timja timja added the skip-changelog Should not be shown in the changelog label Aug 25, 2022
@timja timja requested a review from a team August 25, 2022 20:54
@timja timja merged commit 9aa21f5 into jenkinsci:master Aug 25, 2022
@timja timja deleted the add-blame-ignore branch August 25, 2022 21:34
@basil
Copy link
Member

basil commented Aug 25, 2022

Hrmm, commit f033a61 was a commit with manual changes rather than commit e3fdfa5 which seems to have been an automatically applied PR. Yet this PR updated .git-blame-ignore-revs with commit f033a61. I think manually created commits should probably be in the blame history, while automatic formatting commits should not. Perhaps this was merely an oversight and we meant to put only commit e3fdfa5 in .git-blame-ignore-revs? Or maybe we want to include both?

@timja
Copy link
Member Author

timja commented Aug 26, 2022

Apologies it was a mistake I did not want the manual changes in the ignore file as there is a small chance I made a mistake somewhere and it could cause an issue, I’ll fix in the next hour or so. The stable branches should have the right one ignored already

@timja
Copy link
Member Author

timja commented Aug 26, 2022

#7036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants