Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-68805] Reset cached attributes with ampersand as well #6989

Merged
merged 6 commits into from
Sep 2, 2022

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Aug 12, 2022

See JENKINS-68805.

Alternative to #6988. This simply fixes the problem in the hopes there's no actual reason to exclude strings containing &.

Only makes sense if #6659 isn't merged soon, as that no longer caches attributes.

Proposed changelog entries

  • Properly reset attributes of cached symbols.

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content-Security-Policy directives (see documentation on jenkins.io).
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@daniel-beck daniel-beck added the alternative This PR is one of several options to address a given issue label Aug 12, 2022
@daniel-beck daniel-beck added the bug For changelog: Minor bug. Will be listed after features label Aug 12, 2022
@basil basil requested a review from janfaracik August 30, 2022 22:37
@basil basil requested a review from a team August 31, 2022 20:57
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@NotMyFault NotMyFault added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 1, 2022
@basil basil merged commit fd33b5f into jenkinsci:master Sep 2, 2022
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Sep 17, 2022
NotMyFault pushed a commit to krisstern/jenkins that referenced this pull request Sep 18, 2022
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Sep 20, 2022
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Sep 20, 2022
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alternative This PR is one of several options to address a given issue bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants