-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-69145] bouncing build number element on mouse hover #6928
Conversation
Would this also take care of JENKINS-68160? |
Yes, it also fix JENKINS-68160's problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change it is no longer possible to access the context menu dropdown of model-links. The hover state collapses before I can move the pointer to the chevron.
Screen.Recording.2022-07-30.at.10.18.27.mov
@daniel-beck In my test, it is normal, This is my demo. |
Move your mouse pointer more slowly. I found it sometimes works when moving the pointer fairly quickly. Otherwise, I used Firefox 103 and most pages have some level of zoom >100%, probably was the case here too. |
The latest state of this no longer causes the issue when slowly moving the mouse pointer 👍 Not approving as of now as I've only inconsistently been able to reproduce JENKINS-68160. Requesting @jtnord as the reporter of JENKINS-69145. |
I can verify that JENKINS-69145 is indeed fixed, thankyou! |
Could I get a reviewer for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to reproduce the problem in JENKINS-69145 on weekly.ci.j.io and this PR appears to address it.
Ideally @janfaracik could tell us what the purpose of pointer-events: all
was here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Misclicked in the previous review.)
@janfaracik Do you mind taking a look and could clarify Daniel's open concerns? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!
Manually verified as of commit 93f69b2 |
See JENKINS-69145.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgrade@Restricted
or have@since TODO
Javadoc, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
if applicable.Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are accurate, human-readable, and in the imperative moodupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).