Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-60866][JENKINS-69030] Extract inline JS from 'new-from-list' #6858

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Jul 16, 2022

See JENKINS-60866.

Applying the trick described in #6853 without depending on #6855.

Also addresses the regression JENKINS-69030 introduced in #5842 by reverting the behavior before 2.320: Previously, selecting the 'copy' text field automatically selected the 'copy' radio button. Now, selecting the 'copy' radio button reveals (added in #5842) and then selects (new in this PR) the text field.

Proposed changelog entries

Too minor

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@daniel-beck daniel-beck added the skip-changelog Should not be shown in the changelog label Jul 16, 2022
@daniel-beck daniel-beck changed the title [JENKINS-60866] Remove inline JS from 'new-from-list' name validation [JENKINS-60866][JENKINS-69030] Extract inline JS from 'new-from-list' Jul 16, 2022
@daniel-beck daniel-beck requested a review from janfaracik July 16, 2022 11:33
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not super familiar with this stuff, so I have a few (probably obvious) questions.

Also, even though it is minor, there is a behavior change here apart from the removal of inline JS that might be worth a changelog entry.

@daniel-beck daniel-beck requested a review from dwnusbaum July 18, 2022 18:49
@daniel-beck daniel-beck requested a review from NotMyFault July 18, 2022 19:57
@daniel-beck
Copy link
Member Author

Thanks for the reviews!

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process.

@daniel-beck daniel-beck added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback squash-merge-me Unclean or useless commit history, should be merged only with squash-merge labels Jul 19, 2022
@daniel-beck daniel-beck merged commit 95706a9 into jenkinsci:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants