Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-68941] Make -Dtest=... work again #6791

Closed
wants to merge 1 commit into from

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Jul 6, 2022

See JENKINS-68941. Amends #6652.

When running mvn clean install -Dspotbugs.skip -Dfindbugs.skip -Dcheckstyle.skip -Dspotless.check.skip -Dtest=PluginManagerTest, the cli module build fails without this, but passes with this change.

Proposed changelog entries

(Internal/developer only)

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@daniel-beck daniel-beck requested a review from basil July 6, 2022 08:15
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same is the case for plugins with a Maven multi-module build (e.g., pipeline-model-definition) and other core components with a Maven multi-module build (e.g., lib-access-modifier). I think this is a good idea but I think the right place to fix this is in plugin-pom and pom (the fact that both exist and are largely duplicates of each other is a pre-existing issue, but I try to keep them in sync as much as possible). That way, the fix would apply to the whole organization rather than just this repository. Not against applying it to this repository alone, but I view that as more of a hotfix than a long-term fix. Similar situation with the change James wanted to make recently about redirecting test output to a file: we ended up putting that in place in pom and plugin-pom rather than in core.

@daniel-beck
Copy link
Member Author

Note that I am simply fixing what was broken by the update: The profile for this purpose exists and sets a (now apparently no longer correct) property. I would consider the migration of this behavior upstream a good idea, but out of scope of this PR.

@basil
Copy link
Member

basil commented Jul 6, 2022

And I would consider short-term fixes like this acceptable, but not desirable.

@basil basil closed this Jul 6, 2022
@daniel-beck
Copy link
Member Author

I guess superseded by jenkinsci/pom#274 and #6793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants