Add sidebar to plugin manager, increase search bar size #6783

janfaracik · 2022-07-05T16:35:42Z

This is a small-ish PR to add a sidebar to the plugin manager, as well as to increase the size and prominence of the search bar.

What's changed

New sidebar
Update count now displays in the sidebar
Search bar is now larger and sticks to the top of the page
Misc text changes

Before

After

Screen.Recording.2022-07-05.at.17.32.21.mov

Proposed changelog entries

Add sidebar to plugin manager, increase search bar size

Proposed upgrade guidelines

N/A

Submitter checklist

(If applicable) Jira issue is well described
Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
- Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
Appropriate autotests or explanation to why this change has no tests
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

There are at least 2 approvals for the pull request and no outstanding requests for change
Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
Proper changelog labels are set so that the changelog can be generated automatically
If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

This reverts commit 28aaf91.

timja · 2022-08-20T06:32:10Z

Do you want something done here?

We could try disabling autocomplete if required.

——

Can you clarify what is holding back the approval please?

daniel-beck · 2022-08-20T10:33:45Z

Can you clarify what is holding back the approval please?

Available time and competing priorities. I like to review and test nontrivial changes in depth. What I wrote above was initial feedback when running this PR, haven't gotten around to a more extensive test.

NotMyFault

manage/pluginManager/available's bottom sticker is detached from the background, until you scroll to the bottom of the page and back up:

Kapture.2022-08-23.at.22.34.44.mp4

- I'd be in favor of dropping the search bar suggestions for now, if that's a specific addition of this PR, because this PR targets the sidebar and search bar size. We can reiterate that on a later PR, but I feel minor changes like these end up in delaying PRs longer than needed.

Edit: Disregard the latter, the same behavior is present on recent weeklys.

timja · 2022-08-23T21:32:23Z

manage/pluginManager/available's bottom sticker is detached from the background, until you scroll to the bottom of the page and back up:

I haven't managed to reproduce this (on chrome)

Can you reliably reproduce it? and are there any specific steps

NotMyFault · 2022-08-23T22:08:00Z

Can you reliably reproduce it? and are there any specific steps

Dashboard -> Manage Jenkins -> Manage Plugins -> Available plugins on a clean installation let me reproduce it with Chrome 104.

I can't reproduce it reliable it with Safari or Firefox :/

github-actions · 2022-08-25T20:54:14Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

github-actions · 2022-08-28T08:36:59Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

Changes addressed

NotMyFault

Looks fancy 🎉

I'm fine with disregarding my previous concern, given input suggestions aren't introduced here and do already exist on the past weeklys.

timja · 2022-09-03T20:29:10Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

basil · 2022-09-05T19:35:09Z

Wow, this looks great! I am very pleased with the result and I think this is a huge step forward. I only have one piece of optional non-blocking feedback for your consideration.

When I click on "Download progress" on the sidebar, I get to a page with "Download progress" as its heading. When I click on "Advanced settings" on the sidebar, I get to a page with "Advanced settings" as its heading. However, when I click on "Updates", "Available Plugins", or "Installed Plugins" on the sidebar, I get to a page with "Plugins" as its heading. To me, this is unexpected because I would expect the heading of the page to match the navigation link. To me, this feels like it is possibly a relic of the older implementation (where these three pieces of functionality were on a single page with three tabs) that was unintentionally carried through into the redesigned version. But whether or not it was intentional, it seems inconsistent and therefore a potential source of confusion to users. My vote would be to make the headings consistent with the navigation links in all cases. If I am wrong about something here, please feel free to correct me.

timja · 2022-09-05T21:31:16Z

But whether or not it was intentional, it seems inconsistent and therefore a potential source of confusion to users. My vote would be to make the headings consistent with the navigation links in all cases

I think that will be mostly addressed when #6783 (comment) is sorted.

The title will move into the sidebar and the plugin manager pages themselves won't have a main title.

Basically the 3 tabs are being considered as part of 1 page almost.
advanced being a bit special and it could be somewhat removed with some additional refactoring out of scope of this PR.

If no objections I plan to merge this tomorrow towards the next weekly.

daniel-beck · 2022-09-09T06:58:14Z

war/src/main/less/modules/side-panel-tasks.less

+  .task-icon-badge {
+    position: relative;
+    color: currentColor;
+    letter-spacing: 0;
+    z-index: 0;
+    margin-left: auto;
+    min-width: 24px;
+    text-align: center;
+    padding: 0 8px;
+    line-height: 0.75rem;
+    font-size: 0.75rem;
+
+    &::before {
+      content: "";
+      position: absolute;
+      inset: -6px 0;
+      background: var(--item-background--hover);
+      border-radius: 100px;
+      z-index: -1;
+    }
+  }


Unused in this PR, only used in #7084.

daniel-beck · 2022-09-09T06:58:29Z

war/src/main/less/modules/side-panel-tasks.less

+  .task-link-text {
+    display: contents;
+  }
+
  .task-link-text {
    display: contents;
  }


Improperly resolved conflict, or what is this for?

You're correct 👍 I've removed it as part of #7084

janfaracik added 30 commits April 21, 2022 22:43

Init

b8a622c

Update sidebar

53902db

Finish

addb738

Add loading animation

cf28fee

Update plugin-manager.less

84596ee

Fix translucency on Firefox

dc8ba52

Remove unused icon preload

28aaf91

Revert "Remove unused icon preload"

1cb37d1

This reverts commit 28aaf91.

Init

43e4f5c

Update section.less

d579dc5

Merge branch 'master' into new-plugin-manager-1

f89fe63

Add mixin for items

e925490

Update theme.less

8b22270

Merge branch 'master' into move-manage-jenkins-less

8c4b466

Update mixins.less

929e2d5

Update theme.less

68f5425

Move from px to rem

13d5729

Update table.less

d1f42ac

Merge branch 'master' into move-manage-jenkins-less

28d0638

Rename mixin

90fc4ba

Update breadcrumbs to use new item mixin

e21d4e7

Update style.less

69c1633

Update theme.less

e57bc28

Update theme.less

0996e75

Update theme.less

c78dfd6

Update colors

c9e2823

Merge branch 'master' into move-manage-jenkins-less

2391319

Merge branch 'move-manage-jenkins-less' into new-plugin-manager-1

88b2a59

Update search bar

abcbecf

Update side-panel-tasks.less

87c27c2

NotMyFault reviewed Aug 23, 2022

View reviewed changes

github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Aug 25, 2022

Merge remote-tracking branch 'origin/master' into new-plugin-manager-1

e4ae2c3

github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Aug 25, 2022

basil added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Aug 25, 2022

Merge branch 'master' into new-plugin-manager-1

27b52cd

github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Aug 28, 2022

Merge branch 'master' into new-plugin-manager-1

1699d71

github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Aug 28, 2022

NotMyFault approved these changes Aug 28, 2022

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 3, 2022

timja merged commit 6db88c3 into jenkinsci:master Sep 6, 2022

timja deleted the new-plugin-manager-1 branch September 6, 2022 07:30

This was referenced Sep 6, 2022

Add search bar component #7074

Merged

Add updates count badge to Updates sidebar item #7084

Merged

daniel-beck reviewed Sep 9, 2022

View reviewed changes

timja mentioned this pull request Sep 14, 2022

[JENKINS-68712] updateCenter successfully installs nothing where there's nothing to install #7041

Merged

13 tasks

basil mentioned this pull request Jan 19, 2023

Add Polish translations for Jenkins plugin manager #7593

Merged

14 tasks

janfaracik mentioned this pull request Feb 20, 2023

[JENKINS-70599] restore installNecessaryPlugins redirect destination #7653

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sidebar to plugin manager, increase search bar size #6783

Add sidebar to plugin manager, increase search bar size #6783

janfaracik commented Jul 5, 2022 •

edited by gitpod-io bot

Loading

timja commented Aug 20, 2022

daniel-beck commented Aug 20, 2022 •

edited

Loading

NotMyFault left a comment •

edited

Loading

timja commented Aug 23, 2022

NotMyFault commented Aug 23, 2022 •

edited

Loading

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 28, 2022

NotMyFault left a comment

timja commented Sep 3, 2022

basil commented Sep 5, 2022

timja commented Sep 5, 2022

daniel-beck Sep 9, 2022

daniel-beck Sep 9, 2022

janfaracik Sep 9, 2022

Add sidebar to plugin manager, increase search bar size #6783

Add sidebar to plugin manager, increase search bar size #6783

Conversation

janfaracik commented Jul 5, 2022 • edited by gitpod-io bot Loading

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

timja commented Aug 20, 2022

daniel-beck commented Aug 20, 2022 • edited Loading

NotMyFault left a comment • edited Loading

Choose a reason for hiding this comment

timja commented Aug 23, 2022

NotMyFault commented Aug 23, 2022 • edited Loading

github-actions bot commented Aug 25, 2022

github-actions bot commented Aug 28, 2022

NotMyFault left a comment

Choose a reason for hiding this comment

timja commented Sep 3, 2022

basil commented Sep 5, 2022

timja commented Sep 5, 2022

daniel-beck Sep 9, 2022

Choose a reason for hiding this comment

daniel-beck Sep 9, 2022

Choose a reason for hiding this comment

janfaracik Sep 9, 2022

Choose a reason for hiding this comment

janfaracik commented Jul 5, 2022 •

edited by gitpod-io bot

Loading

daniel-beck commented Aug 20, 2022 •

edited

Loading

NotMyFault left a comment •

edited

Loading

NotMyFault commented Aug 23, 2022 •

edited

Loading