Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font stack to use 'system-ui' #6614

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

janfaracik
Copy link
Contributor

This MR updates the default font stack for Jenkins so that it uses 'system-ui' (https://caniuse.com/font-family-system-ui), this brings better font consistency across browsers and makes Chrome render fonts the same way as other browsers, so Chrome shouldn't over-bold fonts anymore. The character spacing has also been tightened slightly for better legibility.

Safari - Pretty much the same
Before
safari-before

After
safari-after

Chrome - Big difference!
Before
chrome-before

After
chrome-after

Firefox - Pretty much the same
Before
firefox-before

After
firefox-after

Proposed changelog entries

  • Update Jenkins to use default system font on Chrome

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@timja timja requested a review from a team May 30, 2022 21:54
@timja timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label May 30, 2022
@timja timja added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise labels May 31, 2022
@@ -8,7 +8,7 @@ html {
// The downside is that the page does not resize with the browser's font size,
// only with the zoom level.
font-size: 16px !important;
letter-spacing: -0.011em;
letter-spacing: -0.016em;
Copy link
Member

@daniel-beck daniel-beck May 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://developer.mozilla.org/en-US/docs/Web/CSS/letter-spacing

Legible letter-spacing must be determined on a case-by-case basis, as different font families have different character widths. There is no one value that can ensure all font families automatically maintain their legibility.

Is that not a concern here? If we're just using whatever is the system font, won't that mean we have no way of knowing whether messing with letter spacing will work out?

IIRC Windows 98 let me choose crazy fonts as system fonts, is that no longer possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The decrease in letter spacing is extremely minimal so it shouldn't make any system font illegible, happy to undo the change though if need be.

@timja timja merged commit fe04889 into jenkinsci:master Jun 1, 2022
@timja timja deleted the fix-font-stack-macos branch June 1, 2022 07:01
@daniel-beck daniel-beck mentioned this pull request Dec 5, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants