Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD SpotBugs violations #6123

Merged

Conversation

basil
Copy link
Member

@basil basil commented Dec 27, 2021

Suppresses the following remaining ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD. See the code for the justifications.

[ERROR] Medium: Write to static field hudson.slaves.SlaveComputer$LogHolder.SLAVE_LOG_HANDLER from instance method hudson.slaves.SlaveComputer$SlaveInitializer.call() [hudson.slaves.SlaveComputer$SlaveInitializer] At SlaveComputer.java:[line 1051] ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD
[ERROR] Medium: Write to static field hudson.tasks.ArtifactArchiver.DESCRIPTOR from instance method new hudson.tasks.ArtifactArchiver$DescriptorImpl() [hudson.tasks.ArtifactArchiver$DescriptorImpl] At ArtifactArchiver.java:[line 340] ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD
[ERROR] Medium: Write to static field jenkins.security.QueueItemAuthenticatorMonitor.anyBuildLaunchedAsSystemWithAuthenticatorPresent from instance method jenkins.security.QueueItemAuthenticatorMonitor.doAct(String, String, String) [jenkins.security.QueueItemAuthenticatorMonitor] At QueueItemAuthenticatorMonitor.java:[line 83] ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD
[ERROR] Medium: Write to static field jenkins.security.UserDetailsCache.EXPIRE_AFTER_WRITE_SEC from instance method new jenkins.security.UserDetailsCache() [jenkins.security.UserDetailsCache, jenkins.security.UserDetailsCache] At UserDetailsCache.java:[line 67]Another occurrence at UserDetailsCache.java:[line 70] ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD
[ERROR] Medium: Write to static field jenkins.slaves.NioChannelSelector.DISABLED from instance method new jenkins.slaves.NioChannelSelector() [jenkins.slaves.NioChannelSelector] At NioChannelSelector.java:[line 30] ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@StefanSpieker

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added the skip-changelog Should not be shown in the changelog label Dec 27, 2021
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 28, 2021
@timja timja merged commit 8a8c70f into jenkinsci:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants