Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline form element path #5926
Inline form element path #5926
Changes from 1 commit
45bb4c7
2546e62
a5cb4cb
dbc3407
d9e1c10
0c6aac1
a69fec3
035305b
f6069df
0c5b817
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is what I'm most worried about having it on by default, every second recalculating the paths.
I tried removing it but its needed for repeatable elements to have the index added and re-calculated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jenkins already has runtime performance issues and periodic queries, I would avoid this as much as possible.
I'd suggest maybe registering this as a layout update callback (
jenkins/war/src/main/webapp/scripts/hudson-behavior.js
Line 2487 in 3e8afc5
repeatable
is missing I think.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's already registered a couple of lines down, I'll take a look at adding it to repeatable to see if it removes the need for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should probably fix it for most plugins. Don't know if it's a problem that rogue plugins with custom widgets do not have this tbh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in #5926 (review) you should either
buildFormTree
so it happens synchronously if and when a form is submitted.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will probably disable by default but also look to add repeatable to layout update callback so the timer bit can be removed.
The timer bit made debugging this code a pain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe start with the current code copied-and-pasted from the plugin but disabled by default. That at least solves the immediate issue, we can gut the plugin, and simplify ATH to not try to load it.
Then as a follow-up look into whether the actual behavior can be simplified by inlining into
lib/form/*.jelly
and/orhudson-behavior.js
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this blow up somehow if the plugin is also installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to bump the baseline of the plugin and empty it out initially so this shouldn’t really matter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wouldn't blow up anyway just last one to register would win