Modernise the appearance of the plugin manager

[janfaracik]

📸 Screenshots

Proposed changelog entries

• Modernise the appearance of the plugin manager

Proposed upgrade guidelines

N/A

Submitter checklist

• (If applicable) Jira issue is well described
• Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• Appropriate autotests or explanation to why this change has no tests
• For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least 2 approvals for the pull request and no outstanding requests for change
• Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• Changelog entries in the PR title and/or Proposed changelog entries are correct
• Proper changelog labels are set so that the changelog can be generated automatically
• If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[janfaracik]

⬇️ Discussion around this would be good ⬇️
I've added an .editorconfig file to ensure consistency in frontend files going forward, would be good to discuss this to see if theres a demand for this/any issues with it :)

[timja]

Bom testing has passed: jenkinsci/bom#756

ATH was tested in jenkinsci/acceptance-test-harness#716.

and issues are resolved in jenkinsci/acceptance-test-harness#718

I think we're ready to ship this.

Thanks!

[jetersen]

Adding an editorconfig is great, but please add the root = true, so that editor will stop traversing all directories.

[jetersen]

@timja I have no further input. I do not think I can approve the frontend part of it 😅 At least it is looking great, so keep up the good work!

[uhafner]

Well, not much has changed since my last review. The new UI looks much better in most places. I think the deprecated banners are still too close to the text, but that was a problem before.

One thing that I really don't like is the position of the search bar. It is far too wide in the upper right corner (where it looks unrelated) and a lot of users will not find them when opening the new page the first time. It already is not ideal in the current UI (where it is above the tabs rather than right above the table), but now I think the usability is getting worse.

But anyway, we can improve that in followup PRs.

[timja]

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[uhafner]

I created a followup Jira so the remaining review comments will not be forgotten: https://issues.jenkins.io/browse/JENKINS-67366.

[janfaracik]

I created a followup Jira so the remaining review comments will not be forgotten: https://issues.jenkins.io/browse/JENKINS-67366.

Awesome! I've got a follow up branch in the works to address a lot of your comments - thanks :)

[Bananeweizen]

The downgrade buttons are not aligned. Their position depends on the text width of the version number.

[timja]

can you create an issue on https://issues.jenkins.io component core please and link here?

so that someone can take a look when they have time

[basil]

@janfaracik Causes JENKINS-68277.

[basil]

Causes JENKINS-68291.

[daniel-beck]

What's the purpose of editorconfig when the most important JS file in the project isn't following this to begin with? I currently have to fight against editorconfig on every single line I edit in hudson-behavior.js unless I want mixed-width indentation in the file.

[timja]

What's the purpose of editorconfig when the most important JS file in the project isn't following this to begin with? I currently have to fight against editorconfig on every single line I edit in hudson-behavior.js unless I want mixed-width indentation in the file.

Filed #6863

[daniel-beck]

This editorconfig continues to be incredibly annoying, since not all Jelly files are currently indented using 2 spaces.