Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update at-since Javadoc #4877

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Update at-since Javadoc #4877

merged 1 commit into from
Aug 1, 2020

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Jul 27, 2020 •
edited
Loading

Proposed changelog entries

(too minor)

Proposed upgrade guidelines

N/A

Submitter checklist

  • [n/a] (If applicable) Jira issue is well described
  • [n/a] Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • [n/a] Appropriate autotests or explanation to why this change has no tests
  • [n/a] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@daniel-beck daniel-beck added the on-hold This pull request depends on another event/release, and it cannot be merged right now label Jul 27, 2020
daniel-beck
daniel-beck commented Jul 27, 2020
View reviewed changes
core/src/main/java/hudson/FilePath.java
@@ -1262,7 +1262,7 @@ public Boolean invoke(File f, VirtualChannel channel) throws IOException, Interr
/**
* Deletes all suffixes recursively.
* @throws IOException if it exists but could not be successfully deleted
* @since TODO
* @since 2.244
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4824

core/src/main/java/hudson/slaves/WorkspaceList.java
@@ -312,7 +312,7 @@ public static FilePath tempDir(FilePath ws) {

/**
* The token that combines the project name and unique number to create unique workspace directory.
* @since TODO
* @since 2.244
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4824

core/src/main/java/hudson/Functions.java
@@ -1161,7 +1161,7 @@ public static String getFooterURL() {
/**
* Checks if the current security principal has one of the supplied permissions.
*
* @since TODO
* @since 2.238
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4531

core/src/main/java/hudson/Functions.java
@@ -1176,7 +1176,7 @@ public static boolean hasAnyPermission(AccessControlled ac, Permission[] permiss
* degrades gracefully if "it" is not an {@link AccessControlled} object.
* Otherwise it will perform no check and that problem is hard to notice.
*
* @since TODO
* @since 2.238
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4531

core/src/main/java/hudson/Launcher.java
@@ -116,7 +116,7 @@ protected Launcher(@NonNull Launcher launcher) {
* @param run The run that requested the command interpretation, could be <code>null</code> if outside of a run context.
* @param builder The builder that asked to run this command
*
* @since TODO
* @since 2.246
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4683

core/src/main/java/hudson/model/Fingerprint.java
@@ -1192,7 +1192,7 @@ public int size() {
/**
* Returns the persisted facets.
*
* @since TODO
* @since 2.242
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4731

core/src/main/java/hudson/model/Fingerprint.java
@@ -1359,7 +1359,7 @@ public Api getApi() {
/**
* Deletes the {@link Fingerprint} in the Storage with the given unique id.
*
* @since TODO
* @since 2.242
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4731

core/src/main/java/hudson/model/ParameterDefinition.java
@@ -227,7 +227,7 @@ public ParameterValue getDefaultParameterValue() {

/**
* Checks whether a given value is valid for this definition.
* @since TODO
* @since 2.244
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4826

core/src/main/java/hudson/model/DownloadService.java
@@ -460,7 +460,7 @@ public JSONObject reduce(List<JSONObject> jsonList) {
*
* @param clazz The class to use to determine the downloadable's ID.
*
* @since TODO
* @since 2.244
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4773

core/src/main/java/hudson/model/DownloadService.java
@@ -281,7 +281,7 @@ public String getId() {
* @param clazz The class to use to generate an ID.
* @return The ID generated based on the specified class.
*
* @since TODO
* @since 2.244
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4773

@daniel-beck daniel-beck removed the on-hold This pull request depends on another event/release, and it cannot be merged right now label Jul 27, 2020
stellargo
stellargo suggested changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@stellargo stellargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As seen at https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.248, the fingerprint changes were introduced in 2.248. Hence, I have made the changes :)

core/src/main/java/jenkins/fingerprints/FingerprintStorage.java Show resolved Hide resolved
core/src/main/java/jenkins/fingerprints/FingerprintStorage.java Show resolved Hide resolved
core/src/main/java/jenkins/fingerprints/FingerprintStorage.java Show resolved Hide resolved
oleg-nenashev
oleg-nenashev approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.246 and 2.247 weren't properly released, but this is the correct reference.

FWIW the bits are available in Maven, so 2.246 is a right thing to reference there.

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog labels Jul 30, 2020
@timja timja merged commit c632f42 into jenkinsci:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellargo stellargo stellargo approved these changes

@timja timja timja approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daniel-beck @oleg-nenashev @timja @stellargo