[JENKINS-62723] Fix behaviour of Util.isOverridden() #4833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will now deal with final/abstract methods appropriately. It will also clearly report bad arguments (base not base of derived, or base does not declare the method). Added a unit test for interface cases. Small gap to be looked into: overrides provided via default implementation of a (derived) interface.
This handles the remaining case (override provided by default implementation of an interface).
jglick
approved these changes
Jul 7, 2020
jglick
approved these changes
Jul 7, 2020
timja
approved these changes
Jul 8, 2020
res0nance
approved these changes
Jul 8, 2020
timja
added
the
ready-for-merge
|
This PR is ready to merge, and will be merged after 24 hours if there's no objection |
oleg-nenashev
approved these changes
Jul 12, 2020
|
I will merge it once the CI run passes |
olivergondza
pushed a commit
to olivergondza/jenkins
that referenced
this pull request
Jul 29, 2020
(cherry picked from commit f7ae11e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-62723.
Based on #4832 (which provides a unit test reproducing the issue)
Proposed changelog entries
IllegalArgumentException: Method not founderror caused by misbehaviour inUtil.isOverridden()(regression in 2.241)Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@jglick
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).