-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENKINS-61208 Allow system read to view more admin monitors #4685
Changes from 5 commits
4998156
c82a692
cc7efb8
1ecd8b6
e2d5b08
c17a27a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,12 +22,14 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |
THE SOFTWARE. | ||
--> | ||
<?jelly escape-by-default='true'?> | ||
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:f="/lib/form"> | ||
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:f="/lib/form" xmlns:l="/lib/layout"> | ||
<div id="redirect-error" class="alert alert-danger reverse-proxy__hidden" | ||
data-url="${rootURL}/${it.url}/test" data-context="${rootURL}"> | ||
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}"> | ||
<f:submit name="yes" value="${%More Info}"/> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why does this one allow to submit the yes? SYSTEM_READ does have access to view the information the button is redirecting to? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't see any problem if a non-admin user can see the More Info button. It's not configuring anything if IIRC There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's a server side redirect to a jenkins.io redirect, https://github.com/timja/jenkins/blob/system-read-more-admin-monitors/core/src/main/java/hudson/diagnosis/ReverseProxySetupMonitor.java#L118-L126 |
||
<f:submit name="no" value="${%Dismiss}"/> | ||
<l:isAdmin> | ||
<f:submit name="no" value="${%Dismiss}"/> | ||
</l:isAdmin> | ||
</form> | ||
<div>${%blurb}</div> | ||
<div class="js-context-message reverse-proxy__hidden">${%missingContextMessage(rootURL)}</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or "Manage" soon, I suspect