Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks in label-related CauseOfBlockage.print #4616

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 31, 2020

Together with jenkinsci/workflow-durable-task-step-plugin#134 you can see what it looks like before

before

vs. after

after

with links to the label index page

label-index

or via context menu to statistics page

label-stats

Other variants:

no-nodes
next-avail

Proposed changelog entries

  • Allow hyperlinks to be used when displaying causes of blockage related to labels rather than individual nodes.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a JIRA issue should exist and be labeled as lts-candidate

* @since TODO
*/
public static String encodeTo(Label label) {
return encodeTo("/" + label.getUrl(), label.getName());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in

return "label/" + Util.rawEncode(name) + '/';
the URL is encoded automatically, so it does not matter if the label includes URL metacharacters.

@timja timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Apr 1, 2020
@jglick jglick added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 1, 2020
@timja
Copy link
Member

timja commented Apr 4, 2020

Build previously passed with no changes since

@timja timja merged commit 171f876 into jenkinsci:master Apr 4, 2020
@jglick jglick deleted the CauseOfBlockage-label branch April 6, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants