-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-53729] - Restore computed serialVersionUID for HyperlinkNote #3613
[JENKINS-53729] - Restore computed serialVersionUID for HyperlinkNote #3613
Conversation
serialVersionUID
for HyperlinkNote
I checked interactively that this patch works. |
Will this fix result in 2.139+ created hyperlinks not being displayed? |
@daniel-beck Yes, we can either have compatibility with 2.138- or 2.139+ hyperlinks. If you think it would make more sense, we could add the computed serialVersionUID from 2.139 instead. |
A bit unfortunate, but we should prefer 2.138 and earlier. For one thing, that's all LTS releases, and additionally, if build logs of the last two weeks constitute a huge part of all your build logs you're churning so fast that this won't matter in two weeks. At least that let's us write an appropriate changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pick your poison, but I agree with @daniel-beck
See JENKINS-53729 and #3580 (comment).
#3580 changed the computed
serialVersionUID
for HyperlinkNote, which caused errors in new versions of Jenkins when viewing build logs from HyperlinkNotes serialized by older versions of Jenkins.I am happy to try to create a regression test if desired.
Proposed changelog entries
Submitter checklist
* Use the
Internal:
prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@reviewbybees