Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-53729] - Restore computed serialVersionUID for HyperlinkNote #3613

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

dwnusbaum
Copy link
Member

@dwnusbaum dwnusbaum commented Sep 7, 2018

See JENKINS-53729 and #3580 (comment).

#3580 changed the computed serialVersionUID for HyperlinkNote, which caused errors in new versions of Jenkins when viewing build logs from HyperlinkNotes serialized by older versions of Jenkins.

I am happy to try to create a regression test if desired.

Proposed changelog entries

  • Bug: Hyperlinks in build logs for builds run using Jenkins 2.138 or older were not displayed correctly in newer versions of Jenkins.

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@reviewbybees

@dwnusbaum dwnusbaum changed the title Restore computed serialVersionUID for HyperlinkNote Restore computed serialVersionUID for HyperlinkNote Sep 7, 2018
@jglick
Copy link
Member

jglick commented Sep 7, 2018

UpdateCenter2Test broken I guess due to upstream errors, bleh.

I checked interactively that this patch works.

@jglick jglick mentioned this pull request Sep 8, 2018
@daniel-beck
Copy link
Member

Will this fix result in 2.139+ created hyperlinks not being displayed?

@daniel-beck daniel-beck added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases needs-more-reviews Complex change, which would benefit from more eyes labels Sep 8, 2018
@dwnusbaum
Copy link
Member Author

@daniel-beck Yes, we can either have compatibility with 2.138- or 2.139+ hyperlinks. If you think it would make more sense, we could add the computed serialVersionUID from 2.139 instead.

@daniel-beck
Copy link
Member

A bit unfortunate, but we should prefer 2.138 and earlier. For one thing, that's all LTS releases, and additionally, if build logs of the last two weeks constitute a huge part of all your build logs you're churning so fast that this won't matter in two weeks.

At least that let's us write an appropriate changelog.

@oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev changed the title Restore computed serialVersionUID for HyperlinkNote [JENKINS-53729] - Restore computed serialVersionUID for HyperlinkNote Sep 22, 2018
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pick your poison, but I agree with @daniel-beck

@oleg-nenashev oleg-nenashev merged commit 7967e02 into jenkinsci:master Sep 22, 2018
@dwnusbaum dwnusbaum deleted the JENKINS-53016-followup branch September 22, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-reviews Complex change, which would benefit from more eyes regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants