Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-37590] Return a null property if no parameters #2723

Merged
merged 2 commits into from
Feb 9, 2017
Merged

[FIXED JENKINS-37590] Return a null property if no parameters #2723

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a8c4c2
[FIXED JENKINS-37590] Return a null property if no parameters
abayer Jan 20, 2017
0254e02
Reverting last remnants of #2444 from Messages
abayer Jan 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/src/main/java/hudson/model/ParametersDefinitionProperty.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,15 @@ public ParameterDefinition getParameterDefinition(String name) {
@Extension
@Symbol("parameters")
public static class DescriptorImpl extends OptionalJobPropertyDescriptor {
@Override
public ParametersDefinitionProperty newInstance(StaplerRequest req, JSONObject formData) throws FormException {
ParametersDefinitionProperty prop = (ParametersDefinitionProperty)super.newInstance(req, formData);
if (prop != null && prop.parameterDefinitions.isEmpty()) {
return null;
}
return prop;
}

@Override
public boolean isApplicable(Class<? extends Job> jobType) {
return ParameterizedJobMixIn.ParameterizedJob.class.isAssignableFrom(jobType);
Expand Down