Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish translations (added new, removed outdated) #2643

Merged
merged 1 commit into from
Dec 15, 2016
Merged

Polish translations (added new, removed outdated) #2643

merged 1 commit into from
Dec 15, 2016

Conversation

damianszczepanik
Copy link
Member

No description provided.

damianszczepanik
damianszczepanik commented Nov 22, 2016
View reviewed changes
core/src/main/resources/hudson/PluginManager/advanced_pl.properties
@@ -22,14 +22,9 @@

File=Plik
HTTP\ Proxy\ Configuration=Konfiguracja HTTP Proxy
Password=Has\u0142o
Port=Port
Server=Serwer
Submit=Prze\u015Blij
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used translation-tool.pl to remove items that are not presented any more in main properties file

core/src/main/resources/hudson/PluginWrapper/PluginWrapperAdministrativeMonitor/message.jelly
<div class="error">
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
<div style="float:right">
<f:submit name="correct" value="${%Correct}"/>
</div>
</form>
There are dependency errors loading some plugins:
${%Dependency errors}:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New translation

...main/resources/hudson/PluginWrapper/PluginWrapperAdministrativeMonitor/message_pl.properties
@@ -0,0 +1,23 @@
# The MIT License
#
# Copyright (c) 2004-2016, Kohsuke Kawaguchi, Sun Microsystems, Inc., and a number of other of contributors
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the most generic copyrights I've found, actually for new files it is used by default

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New files should just be 2016, Damian Szczepanik.

daniel-beck
daniel-beck reviewed Nov 23, 2016
View reviewed changes
core/src/main/resources/lib/form/apply_pl.properties
@@ -1,3 +0,0 @@
# This file is under the MIT License by authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the apply*.properties files obsolete? If so, and in case you need to update this PR anyway, could you delete the others?

daniel-beck
daniel-beck reviewed Nov 25, 2016
View reviewed changes
...rc/main/resources/hudson/PluginWrapper/PluginWrapperAdministrativeMonitor/message.properties
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
Correct=Napraw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong.

@daniel-beck daniel-beck added needs-comments-resolved Comments in the PR need to be addressed before it can be considered for merging needs-more-reviews Complex change, which would benefit from more eyes labels Nov 25, 2016
@damianszczepanik
Copy link
Member Author

Updated

@daniel-beck daniel-beck removed the needs-comments-resolved Comments in the PR need to be addressed before it can be considered for merging label Nov 26, 2016
@daniel-beck
Copy link
Member

https://github.com/jenkinsci/jenkins/pull/2643/files#diff-83ed02917a79a86aca695d231dd611a1 Git 😆

Will look this over in more detail over the weekend to make sure nothing else cropped in accidentally, then merge.

oleg-nenashev
oleg-nenashev reviewed Nov 27, 2016
View reviewed changes
core/src/main/resources/hudson/Messages_pl.properties
@@ -1,6 +1,6 @@
# The MIT License
#
# Copyright (c) 2016, Damian Szczepanik
# Copyright (c) 2004-2016, Kohsuke Kawaguchi, Sun Microsystems, Inc., and a number of other of contributors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the original version since you're the main contributor of this translation file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #2643 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that I was not the owner of this file but I see I was wrong. Change restored

@damianszczepanik
Copy link
Member Author

PR updated

oleg-nenashev
oleg-nenashev approved these changes Dec 11, 2016
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed needs-more-reviews Complex change, which would benefit from more eyes labels Dec 15, 2016
@oleg-nenashev
Copy link
Member

@daniel-beck Are you fine with the PR?

@daniel-beck
Copy link
Member

@oleg-nenashev No objections.

@oleg-nenashev oleg-nenashev merged commit bd6a7d6 into jenkinsci:master Dec 15, 2016
oleg-nenashev added a commit that referenced this pull request Dec 16, 2016
@oleg-nenashev
Changelog: updates towards 2.37
1c1e9d5 
Noting #2668, #2664, #2663, #2662, #2661, #2667, #2666, #2652, #2643, #2591, #2658, #2645, #2660, #2603
@damianszczepanik damianszczepanik deleted the translations branch August 9, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-beck daniel-beck daniel-beck left review comments

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damianszczepanik @daniel-beck @oleg-nenashev