[JENKINS-27530] nextBuildNumber snafu after reload #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure that every Queue.Item.task corresponds to a live Job, lest nextBuildNumber be bogus.
| this.nextBuildNumber = Collections.max(foldersInt) + 1; | ||
| RunT lB = getLastBuild(); | ||
| synchronized (this) { | ||
| this.nextBuildNumber = lB != null ? lB.getNumber() + 1 : 1; |
There was a problem hiding this comment.
Could leave the original implementation of JENKINS-11563 untouched for a non-LazyLoadingJob, but may as well use this simpler implementation.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
🐝 |
|
🐝 and 🎉 for including some cleanup and defensive cases for other possibilities. |
|
🐝 |
jglick
added a commit
that referenced
this pull request
Jul 8, 2016
oleg-nenashev
pushed a commit
that referenced
this pull request
Jul 15, 2016
…uild.] (#2444) * Fixed JENKINS-33201 [Java JSON exception with an empty parametrized build.] * FIXED JENKINS-33201. Changed to FormException instead of Failure * That fix was never in a released version. So it cannot have been reverted. * Lowercase i for consistency * Remove the concept of yanking dead executors. * Another unnecessary call to doYank. * [FIXED JENKINS-27530] Jenkins.reload must also reload the Queue to ensure that every Queue.Item.task corresponds to a live Job, lest nextBuildNumber be bogus. * [JENKINS-27530] Noting #2439 & #2440. * FIXED JENKINS-33201. Changed to FormException instead of Failure * [FIXED JENKINS-33201 .FormException is thrown if parameterDefinitions are not available . * Changing one more Tab to Space * Moved checkForEmptyParameters to Job class
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-27530
Only purports to address the issue of reloading Jenkins while there are builds waiting in the queue. An apparent
MatrixConfigurationbug will be investigated separately.@reviewbybees