[JENKINS-32777] Cover 'delete-builds' CLI by tests #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Test public void deleteBuildsShouldSuccessEvenTheBuildIsRunning() throws Exception { | ||
| FreeStyleProject project = j.createFreeStyleProject("aProject"); | ||
| project.getBuildersList().add(new Shell("echo 1\nsleep 10s")); |
There was a problem hiding this comment.
This is fragile. Something like ExecutorTest.BlockingBuilder should be used.
|
LGTM |
|
|
||
| @Test public void deleteBuildsManyShouldSuccessEvenTheFirstAndLastBuildDoesNotExist() throws Exception { | ||
| FreeStyleProject project = j.createFreeStyleProject("aProject"); | ||
| project.scheduleBuild2(0).get(); |
There was a problem hiding this comment.
j.buildAndAssertSuccess would hide some implementation details. Not important
|
👍 |
oleg-nenashev
added
the
ready-for-merge
|
@olivergondza Regarding your comment... Do you want to get it fixed before the merge? |
|
@oleg-nenashev Yes, I'll fix it before merge. |
oleg-nenashev
added
work-in-progress
Slighty optimized and better legible asserts
oleg-nenashev
added
needs-more-reviews
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review, thx. Pavel